From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D523EC433EF for ; Thu, 14 Oct 2021 17:53:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5444D61152 for ; Thu, 14 Oct 2021 17:53:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5444D61152 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CA0D3900003; Thu, 14 Oct 2021 13:53:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4FEF900002; Thu, 14 Oct 2021 13:53:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1754900003; Thu, 14 Oct 2021 13:53:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id 9DBB6900002 for ; Thu, 14 Oct 2021 13:53:52 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5089232617 for ; Thu, 14 Oct 2021 17:53:52 +0000 (UTC) X-FDA: 78695791104.25.7BB00A9 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf24.hostedemail.com (Postfix) with ESMTP id BEB5FB00009D for ; Thu, 14 Oct 2021 17:53:50 +0000 (UTC) Received: by mail-qv1-f44.google.com with SMTP id z15so4202094qvj.7 for ; Thu, 14 Oct 2021 10:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zJB8zVukIQ+/02Rc0y98q23z81gJRt8QzQtT1HzSbCg=; b=ELuQkXd9ubC+OOcBV7fXc70bOKtTagxKSxoApRUZ/4BsKndSk0l6tVMuHdx9fGF8zH GORoT66pFq9wl8kI1VG/IbM0ZkQtbmbFy28q5ZyHmlwRLBj6NWqSXekY1Otqk933Qbv7 ZzzvXg8ECuwL+T68M4ziC52MUIzd1A/c3vjxaTKvNjOdZKbK5kJbRJOctsmBzxNUL/YD 1THlLPXxUs/+yF6XR1swIr/l3cprEL6aLrnPAQw8H4lRzMDB8F20ARkbeGD9svke4yjt Whnosw86G4eJkcVRzBte5sAgcWStb1FwWIYYSpxBMgiIP2ZHEgXw9eYXD0AKGy59C/HR pa9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zJB8zVukIQ+/02Rc0y98q23z81gJRt8QzQtT1HzSbCg=; b=KyUrRUXBDNNk03chlfdf7ThRoUUfC3bVo1Wr7wds8SuKZz47aHLiSCuYOPJhtcX74M Tlz3+WyhtZhEc0tw6bqfA7BR2N6ukxKDOsA4+DOQYGim4H6tg4wduP/9rjHXzbIcIRR9 ZoBKrbv+dLWf7Dltp6czWOSUQhTlkzQkVzvRyxMdJc+ZJejODdZIl8drtl33u6L9uuX+ XVc899sHGbyuILgto09C1WSUZ7kheQZcKQBzStf/Ue76CIbT0OlY1rrURUvr8FFx7rSB XbGNfulhPP7TuePvFtSLHGit0oat5Usyi/MDcXznA5/oVGKu7yCRlvPd8cmVGCsWrjkI XI6g== X-Gm-Message-State: AOAM531/I3yYsH0efVQW0vlRRyz39eAwnH6mRhApMRkhgKVO1z3M424U TVBZWECakJUErHO2YbwpDt8S4g== X-Google-Smtp-Source: ABdhPJxs6J1YFfPVOY54XBg+m6W3BkcHF+q5DixWAchSuTpZvRCuu3J2EDc22HFiu2RbpWn8URKa0w== X-Received: by 2002:a0c:e885:: with SMTP id b5mr6594010qvo.18.1634234031011; Thu, 14 Oct 2021 10:53:51 -0700 (PDT) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id l3sm896707qkj.18.2021.10.14.10.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 10:53:50 -0700 (PDT) Date: Thu, 14 Oct 2021 13:53:49 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Michal Hocko , Mel Gorman , Uladzislau Rezki , Vasily Averin , Roman Gushchin , Matthew Wilcox , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT Message-ID: References: <20211014151607.2171970-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211014151607.2171970-1-shakeelb@google.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BEB5FB00009D X-Stat-Signature: psf8gkhx7r5fd8gjs5bcs3mx3ykhiung Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=ELuQkXd9; spf=pass (imf24.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-HE-Tag: 1634234030-242714 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 14, 2021 at 08:16:07AM -0700, Shakeel Butt wrote: > The commit 5c1f4e690eec ("mm/vmalloc: switch to bulk allocator in > __vmalloc_area_node()") switched to bulk page allocator for order 0 > allocation backing vmalloc. However bulk page allocator does not support > __GFP_ACCOUNT allocations and there are several users of > kvmalloc(__GFP_ACCOUNT). > > For now make __GFP_ACCOUNT allocations bypass bulk page allocator. In > future if there is workload that can be significantly improved with the > bulk page allocator with __GFP_ACCCOUNT support, we can revisit the > decision. > > Fixes: 5c1f4e690eec ("mm/vmalloc: switch to bulk allocator in __vmalloc_area_node()") > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner