From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35BA1C433F5 for ; Thu, 14 Oct 2021 16:41:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EC79D61139 for ; Thu, 14 Oct 2021 16:41:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC79D61139 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 553756B0071; Thu, 14 Oct 2021 12:41:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DC826B0072; Thu, 14 Oct 2021 12:41:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CAF56B0073; Thu, 14 Oct 2021 12:41:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 2D3EC6B0071 for ; Thu, 14 Oct 2021 12:41:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D3CC02BA87 for ; Thu, 14 Oct 2021 16:41:32 +0000 (UTC) X-FDA: 78695608824.25.953EA43 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 9AFFCB00009E for ; Thu, 14 Oct 2021 16:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fxcLVRG2Jku0ajx1R51YzWOEmjfFWOgHA52RS+phND0=; b=hJChu81HMFnOk2mOnqyhd+aZtv 3RzV8zPkoJkUHzUTz5GgiZ+listhRDQekfOBkR90UtQ2T1RzDS9xEDu+Xg8X6MpGuaPXdTpJENrP+ N9lL4PeVE+DrKuffpedBb6bGoElR+WBOPDTHCqD/0FdDaj2E3SOaJdIB8LZ0jOe1/lg1Wx2fVq29b /pGZtjz7ji+oGbkLPezf8ivP5RJ20y0B2SqhEYs3dFDfEWnNSUQoHSWexPFklVi1xKgZUBUzD4jvp Z0D9PwJQldNvfJyOvWouJg6sE1rfP4OM+KHdUwffPvVoYHqOKxa84aqjmiMUJprcaZXS2lBIKYutb cHcfxkiA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mb3mJ-008SzI-UQ; Thu, 14 Oct 2021 16:40:35 +0000 Date: Thu, 14 Oct 2021 17:40:23 +0100 From: Matthew Wilcox To: Alex Sierra Cc: akpm@linux-foundation.org, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com, apopple@nvidia.com Subject: Re: [PATCH v1 1/2] ext4/xfs: add page refcount helper Message-ID: References: <20211014153928.16805-1-alex.sierra@amd.com> <20211014153928.16805-2-alex.sierra@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211014153928.16805-2-alex.sierra@amd.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9AFFCB00009E X-Stat-Signature: uem9d6mxsq9o4dbokwo8sxen1d81zu3o Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hJChu81H; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1634229690-456496 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 14, 2021 at 10:39:27AM -0500, Alex Sierra wrote: > From: Ralph Campbell > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell > Signed-off-by: Alex Sierra > Reviewed-by: Christoph Hellwig > Acked-by: Theodore Ts'o > Acked-by: Darrick J. Wong Reviewed-by: Matthew Wilcox (Oracle)