From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 396A5C433EF for ; Thu, 14 Oct 2021 14:46:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CA3E260F23 for ; Thu, 14 Oct 2021 14:46:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA3E260F23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3F940900003; Thu, 14 Oct 2021 10:46:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A908900002; Thu, 14 Oct 2021 10:46:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2976E900003; Thu, 14 Oct 2021 10:46:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id 1AC0F900002 for ; Thu, 14 Oct 2021 10:46:04 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A226D2DED0 for ; Thu, 14 Oct 2021 14:46:03 +0000 (UTC) X-FDA: 78695317806.33.AFC5101 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf09.hostedemail.com (Postfix) with ESMTP id E606B3000100 for ; Thu, 14 Oct 2021 14:46:02 +0000 (UTC) Received: by mail-qt1-f170.google.com with SMTP id i1so5947128qtr.6 for ; Thu, 14 Oct 2021 07:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TGPp3QpJpJ141U9yeWl+a+2g/BVVjWKEO91eJs21Hfk=; b=QFy6Mi2z8Kldcn4G6XIOJH0lh8f3SYLh+rPvcnxLiNaCn8Rz5vH8187aRZ617o+4q0 1b/XeB7iad/yBYxZgURgufTlMQYK/sEu8KxNMFBD+LRCYm8cEMoftnrOeSR2b2RA9USr r9AIu/rJHLy9R+bLiT3tS56AtpS7TpgEUW2W7pFcbS8fSMnMOcmCeV4aACIeO4plfmIu 8ub4/2fdPXCsipsLVpatikdII3KyNOUwUp8MJDPjkZ3STWiokau3L/AH/9L38Y6nScHO /VAmUZg9bTTBqK0e/LFUzb+nQK98CWAhNSZbqHiXtfp5DcqK/a0v+T2wAfniMR6yyRW8 960Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TGPp3QpJpJ141U9yeWl+a+2g/BVVjWKEO91eJs21Hfk=; b=wxClKrsZlfduCDRu3i7XY9PgmY2jRcYijQkHX/gH5lOm4BmRyPqgqYNXM3kPd/MYm8 lxwI44DkOEx6CjBpqIRp+60xBrSqAvLzG2tRn2lExq7uop5afZv4Xp9BrRITAZxrkicX HRLfyP3f95CQ4TaqYMXg6S6h+LMXBWD9ola6yM4maIBqkPbQsUDCPf/obZgYRjN6VLmI YbRLss9VM44ZfQR6scxMZOWqYcpEKeG4+B3WSSoUbK3HwFyyJ0d1eURE/RHcMnU12yn8 o9TxsmIPyhjultydJO90MsKitv8srxViBI67XRJyCCw9a1IhCe4+7uFBhxhwiGCJyZbd +k/w== X-Gm-Message-State: AOAM531HRRs9SvePhCQri15XtDKc5gSncLzgiWi2+E/9xH3PvOdKxxNt 5p8oY49ZL1Ipn2L5HCvyMA== X-Google-Smtp-Source: ABdhPJyAtwEB+aqbfv0H1uUK0NBx3De4Dn3GmcFlOsAe7LDREAd0ZmU0/SXghhGFx62bEPBunF414A== X-Received: by 2002:a05:622a:54c:: with SMTP id m12mr779161qtx.192.1634222762473; Thu, 14 Oct 2021 07:46:02 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id i85sm1421227qke.61.2021.10.14.07.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 07:46:01 -0700 (PDT) Date: Thu, 14 Oct 2021 10:45:59 -0400 From: Kent Overstreet To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk, alexander.h.duyck@linux.intel.com Subject: Re: [PATCH 1/5] mm: Make free_area->nr_free per migratetype Message-ID: References: <20211013160034.3472923-1-kent.overstreet@gmail.com> <20211013160034.3472923-2-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E606B3000100 X-Stat-Signature: pxrd9ig8hhgoa97kk5qq3b5yccpe33fr Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QFy6Mi2z; spf=pass (imf09.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1634222762-5501 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 06:33:06PM +0200, David Hildenbrand wrote: > > @@ -9317,6 +9319,7 @@ void __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn) > > struct page *page; > > struct zone *zone; > > unsigned int order; > > + unsigned int migratetype; > > unsigned long flags; > > > > offline_mem_sections(pfn, end_pfn); > > @@ -9346,7 +9349,8 @@ void __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn) > > BUG_ON(page_count(page)); > > BUG_ON(!PageBuddy(page)); > > order = buddy_order(page); > > - del_page_from_free_list(page, zone, order); > > + migratetype = get_pfnblock_migratetype(page, pfn); > > As the free pages are isolated, theoretically this should be > MIGRATE_ISOLATE. Thanks for noticing that - I somehow missed the fact that pageblock migratetypes change at runtime, so my patch is wrong. I'm going to have to rework my patch to store the migratetype of free pages in the page itself.