From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B12C433EF for ; Thu, 14 Oct 2021 14:28:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C5C16109E for ; Thu, 14 Oct 2021 14:28:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8C5C16109E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E6CC7900003; Thu, 14 Oct 2021 10:28:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1C18900002; Thu, 14 Oct 2021 10:28:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D326E900003; Thu, 14 Oct 2021 10:28:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id C55A6900002 for ; Thu, 14 Oct 2021 10:28:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 894208249980 for ; Thu, 14 Oct 2021 14:28:51 +0000 (UTC) X-FDA: 78695274462.11.318C43F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 9EB27801A89C for ; Thu, 14 Oct 2021 14:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=saaEW/JUFx/dk1YX0uUtbSq9f1ztgQrV+3IzEx5+zBk=; b=YjxHhm2CUacKiivFVXlfDu1ixl dVuuZ5o97RrcceD7vr5kSFWTJue0bY6DNifIMDJ8HPvkjG1F7FekDTEEwRnbdrd3/j1rIqOsAj2IW yu/x2PBKn9vMSbiDp/hvq4aDonwpnflmCSJ6oAE0AZQQIiuE1ZcFJlrxYmKlpoYxS3ALLGIfhoCnj bbJiJJjX5xfg6R+f3F3tI9NUuXNP3zH5jmWfnfw0q627gjrVeYYkiGfyNwzyegVdJS1Lqtc0z5jja QXaSG0E0rwB2tIKBBcsOs9M1T85StaLkJfUySiXZ/mZvs+N1KHXGsyd6HeBnJt32xY2IyCvtYu4Tl RDOaEIBA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mb1hl-008OOe-41; Thu, 14 Oct 2021 14:27:48 +0000 Date: Thu, 14 Oct 2021 15:27:33 +0100 From: Matthew Wilcox To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk, alexander.h.duyck@linux.intel.com Subject: Re: [PATCH 5/5] brd: Kill usage of page->index Message-ID: References: <20211013160034.3472923-1-kent.overstreet@gmail.com> <20211013160034.3472923-6-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013160034.3472923-6-kent.overstreet@gmail.com> X-Rspamd-Queue-Id: 9EB27801A89C X-Stat-Signature: h781tm5aixaunh63tfbpnhrs6tho7bp4 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YjxHhm2C; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam02 X-HE-Tag: 1634221730-96500 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 12:00:34PM -0400, Kent Overstreet wrote: > As part of the struct page cleanups underway, we want to remove as much > usage of page->mapping and page->index as possible, as frequently they > are known from context. > > In the brd code, we're never actually reading from page->index except in > assertions, so references to it can be safely deleted. > > Signed-off-by: Kent Overstreet More than that ... this is essentially asserting that the radix tree code works, and we have a test suite to ensure that. Reviewed-by: Matthew Wilcox (Oracle)