From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AA97C433F5 for ; Thu, 14 Oct 2021 07:18:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 198BF60ED4 for ; Thu, 14 Oct 2021 07:18:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 198BF60ED4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9F0D294001E; Thu, 14 Oct 2021 03:18:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A07594001C; Thu, 14 Oct 2021 03:18:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88F7994001E; Thu, 14 Oct 2021 03:18:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 7729794001C for ; Thu, 14 Oct 2021 03:18:11 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3B7788249980 for ; Thu, 14 Oct 2021 07:18:11 +0000 (UTC) X-FDA: 78694189182.20.2666BCD Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf11.hostedemail.com (Postfix) with ESMTP id BB819F0000A1 for ; Thu, 14 Oct 2021 07:18:10 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A3D9521A75; Thu, 14 Oct 2021 07:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1634195887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ItroEyfCjdn2jjHo+KgVNqOCeGtBLeeRzaYF2ey/Y8Q=; b=VfMKwkcQxdhoIzXhSYvkSm5ku7ugoTIPQVOo+JxVkpz/QxhwL/Po2BnNIQE8tm4as/wMbN S5oH/v78OyHEvUfHBoe4nVgfGedVIE5BtuoePId8+oLCWf/4EVJCEXyDsURoyy63WUne46 6hmbURCIwobyelAtwxmnd6qGC94sRWw= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 8F5C9A3B84; Thu, 14 Oct 2021 07:18:07 +0000 (UTC) Date: Thu, 14 Oct 2021 09:18:07 +0200 From: Michal Hocko To: Vasily Averin Cc: Shakeel Butt , Johannes Weiner , Mel Gorman , Uladzislau Rezki , Roman Gushchin , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT Message-ID: References: <20211013194338.1804247-1-shakeelb@google.com> <4c92e227-2abc-c3cb-93eb-f5c45bef7fc6@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c92e227-2abc-c3cb-93eb-f5c45bef7fc6@virtuozzo.com> X-Stat-Signature: on48peapis7cmzkigsycg9aobkykn9zx Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=VfMKwkcQ; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BB819F0000A1 X-HE-Tag: 1634195890-861288 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 14-10-21 10:05:21, Vasily Averin wrote: [...] > > + /* Bulk allocator does not support memcg accounting. */ > > + if (unlikely(gfp & __GFP_ACCOUNT)) > > + goto out; > > + > > May be (memcg_kmem_enabled() && (gfp & __GFP_ACCOUNT)) check is better here? Yes please -- Michal Hocko SUSE Labs