From: Michal Hocko <mhocko@suse.com>
To: Vasily Averin <vvs@virtuozzo.com>
Cc: Shakeel Butt <shakeelb@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@techsingularity.net>,
Uladzislau Rezki <urezki@gmail.com>, Roman Gushchin <guro@fb.com>,
Andrew Morton <akpm@linux-foundation.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT
Date: Thu, 14 Oct 2021 09:18:07 +0200 [thread overview]
Message-ID: <YWfZr+lL2lrBhSc/@dhcp22.suse.cz> (raw)
In-Reply-To: <4c92e227-2abc-c3cb-93eb-f5c45bef7fc6@virtuozzo.com>
On Thu 14-10-21 10:05:21, Vasily Averin wrote:
[...]
> > + /* Bulk allocator does not support memcg accounting. */
> > + if (unlikely(gfp & __GFP_ACCOUNT))
> > + goto out;
> > +
>
> May be (memcg_kmem_enabled() && (gfp & __GFP_ACCOUNT)) check is better here?
Yes please
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-10-14 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 19:43 Shakeel Butt
2021-10-13 22:03 ` Roman Gushchin
2021-10-13 22:26 ` Shakeel Butt
2021-10-13 23:15 ` Roman Gushchin
2021-10-13 23:45 ` Shakeel Butt
2021-10-14 0:06 ` Roman Gushchin
2021-10-14 0:08 ` Matthew Wilcox
2021-10-14 7:05 ` Vasily Averin
2021-10-14 7:18 ` Michal Hocko [this message]
2021-10-14 7:16 ` Michal Hocko
2021-10-14 15:01 ` Shakeel Butt
2021-10-14 15:13 ` Michal Hocko
2021-10-14 15:23 ` Johannes Weiner
2021-10-14 17:43 ` Vasily Averin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWfZr+lL2lrBhSc/@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=shakeelb@google.com \
--cc=urezki@gmail.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox