From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EE50C433EF for ; Wed, 13 Oct 2021 11:35:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C406F610D1 for ; Wed, 13 Oct 2021 11:35:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C406F610D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 70C976B0071; Wed, 13 Oct 2021 07:35:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BD456B0072; Wed, 13 Oct 2021 07:35:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AC3F6B0073; Wed, 13 Oct 2021 07:35:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 4C9386B0071 for ; Wed, 13 Oct 2021 07:35:26 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1160C31E65 for ; Wed, 13 Oct 2021 11:35:26 +0000 (UTC) X-FDA: 78691208652.40.465473C Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP id AA451F00038D for ; Wed, 13 Oct 2021 11:35:25 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id EF65561027; Wed, 13 Oct 2021 11:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634124924; bh=Ew/eQo/93Bchex5IgKhMWzqA884BlihcmHekA2AuKz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SPmjnkDSb5sEEV9uMRXqRJjVTS54T4sJ05ja57VRtyZIWHEKgub42Srx6oyMcYT1l PcWjzt8lTQDDy6ZJ5mTzNPT9AbPVz7zSGaA9DGYWHKk/7lBkLceOdG0b3XCAnfkoOG 0aA4dIgsbxchHemPZpgxcxHY+8UgRo6w5uE+S+JfLG5lq1QLLeisNnD53bLshcYVGG PeG8C/LI8r4nrNSa8dFbxuJ3kKdfZ2nrI0RvcVuurF49uu8lckjDa2NU3vrmU7DVMm 9sZMMn1UFT8+PxUUhEbxmItW3oDgFp2y9yfOwIhJZklvj4GhBeNWigGQhbk2j4Wo1N vIiNHwTnMx35g== Date: Wed, 13 Oct 2021 14:35:18 +0300 From: Mike Rapoport To: Catalin Marinas Cc: linux-mm@kvack.org, Andrew Morton , Mike Rapoport , Vladimir Zapolskiy , linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock: exclude NOMAP regions from kmemleak Message-ID: References: <20211013054756.12177-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AA451F00038D X-Stat-Signature: 94wjr853psr4we9mnmcdng8i9ex3k7xc Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SPmjnkDS; spf=pass (imf17.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1634124925-740145 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 08:45:40AM +0100, Catalin Marinas wrote: > On Wed, Oct 13, 2021 at 08:47:56AM +0300, Mike Rapoport wrote: > > From: Mike Rapoport > > > > Vladimir Zapolskiy reports: > > > > commit a7259df76702 ("memblock: make memblock_find_in_range method private") > > invokes a kernel panic while running kmemleak on OF platforms with nomaped > > regions: > > > > Unable to handle kernel paging request at virtual address fff000021e00000 > > [...] > > scan_block+0x64/0x170 > > scan_gray_list+0xe8/0x17c > > kmemleak_scan+0x270/0x514 > > kmemleak_write+0x34c/0x4ac > > > > Indeed, NOMAP regions don't have linear map entries so an attempt to scan > > these areas would fault. > > > > Prevent such faults by excluding NOMAP regions from kmemleak. > > > > Link: https://lore.kernel.org/all/8ade5174-b143-d621-8c8e-dc6a1898c6fb@linaro.org > > Fixes: a7259df76702 ("memblock: make memblock_find_in_range method private") > > Signed-off-by: Mike Rapoport > > Tested-by: Vladimir Zapolskiy > > Acked-by: Catalin Marinas Thanks! I'm going to take it via memblock tree if that's fine with everybody. -- Sincerely yours, Mike.