From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F861C433F5 for ; Wed, 13 Oct 2021 07:45:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3333A60F94 for ; Wed, 13 Oct 2021 07:45:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3333A60F94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CCBA194000F; Wed, 13 Oct 2021 03:45:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7B42940007; Wed, 13 Oct 2021 03:45:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B91E894000F; Wed, 13 Oct 2021 03:45:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id A7527940007 for ; Wed, 13 Oct 2021 03:45:46 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 65D748249980 for ; Wed, 13 Oct 2021 07:45:46 +0000 (UTC) X-FDA: 78690629892.18.80266A5 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP id 10BD4D00009B for ; Wed, 13 Oct 2021 07:45:45 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 1077660EDF; Wed, 13 Oct 2021 07:45:43 +0000 (UTC) Date: Wed, 13 Oct 2021 08:45:40 +0100 From: Catalin Marinas To: Mike Rapoport Cc: linux-mm@kvack.org, Andrew Morton , Mike Rapoport , Vladimir Zapolskiy , linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock: exclude NOMAP regions from kmemleak Message-ID: References: <20211013054756.12177-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013054756.12177-1-rppt@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 10BD4D00009B X-Stat-Signature: ndmm7uytfuqtho6tet8erctewu3z7k91 Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-HE-Tag: 1634111145-174696 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 13, 2021 at 08:47:56AM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > Vladimir Zapolskiy reports: > > commit a7259df76702 ("memblock: make memblock_find_in_range method private") > invokes a kernel panic while running kmemleak on OF platforms with nomaped > regions: > > Unable to handle kernel paging request at virtual address fff000021e00000 > [...] > scan_block+0x64/0x170 > scan_gray_list+0xe8/0x17c > kmemleak_scan+0x270/0x514 > kmemleak_write+0x34c/0x4ac > > Indeed, NOMAP regions don't have linear map entries so an attempt to scan > these areas would fault. > > Prevent such faults by excluding NOMAP regions from kmemleak. > > Link: https://lore.kernel.org/all/8ade5174-b143-d621-8c8e-dc6a1898c6fb@linaro.org > Fixes: a7259df76702 ("memblock: make memblock_find_in_range method private") > Signed-off-by: Mike Rapoport > Tested-by: Vladimir Zapolskiy Acked-by: Catalin Marinas