From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1FBFC433FE for ; Wed, 13 Oct 2021 03:07:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7A28560235 for ; Wed, 13 Oct 2021 03:07:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7A28560235 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 183FD6B006C; Tue, 12 Oct 2021 23:07:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 133E26B0071; Tue, 12 Oct 2021 23:07:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3D71900002; Tue, 12 Oct 2021 23:07:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id E0FCD6B006C for ; Tue, 12 Oct 2021 23:07:06 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9E3588249980 for ; Wed, 13 Oct 2021 03:07:06 +0000 (UTC) X-FDA: 78689927652.24.399F493 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 315C97001A08 for ; Wed, 13 Oct 2021 03:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634094425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g2lNgN2bb+PQK+zV9pywKYhDEw1L0D7XEUTIckJ/sQA=; b=ShdIwe4QRHYsGL6PeFwfD4NdyB3iv5HxHe16i+DzmuQRheankG1lwYOhIaifsmDCw7TKeI MWdJHj4nZ++7aP3LaXnmvWNn46+SEjmIbF9cb4q6mmZjFqt1FO5EuaiLSzTfJhp5c2K5b+ 5exOeuS3HcajPwxgH8czXWtOHK+HT1c= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-iUeh_LU2Ol-ONEU5gT6tvQ-1; Tue, 12 Oct 2021 23:07:02 -0400 X-MC-Unique: iUeh_LU2Ol-ONEU5gT6tvQ-1 Received: by mail-pl1-f200.google.com with SMTP id i3-20020a170902eb4300b0013f5d8f38d8so359815pli.9 for ; Tue, 12 Oct 2021 20:07:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g2lNgN2bb+PQK+zV9pywKYhDEw1L0D7XEUTIckJ/sQA=; b=WPD4/F0GOTkzCwFeA6LLj+JCif+eQ+is8fS/R/h4m7ztp9n5Y0K5QfDdLEgZybNuJZ goGl94A/APz2btB0ZxupMFr9GJV8oxbgL4cHn1mkVm+9eYG37v5eKZrv+s8qIZrsz3ps pDFvLlNpy/hre1DQn4hVPe1/+MNRsd0UksnmJXtsKUnZP0g4gHAHAl/nNzGT0mlCVIbw gNVuFPrv6TKN1HcSlDkkUTbpjFUYG1v5U/lsMT4ILu2FVn2YeSl8DBAfRYaxmCHnr7/n ajAT4OMGeiklNWO1C4o+aEM+PK5DwJBL3wdK3CNImSesMJ63/sEjjV1FHAvLwrndODGx 0iIQ== X-Gm-Message-State: AOAM533AlPcqtLTMMzIJG5Nj0uqTQVMJ74nSaTfIGll8NVXceIYejP1t ooXYRE+clyslngbHKMEY0fJUTRMwoCKzCd+hFoxME+1qdnb4IEHrc6sh9j9VmKxNNtPDgH+18U6 EwsHhthuEBGA= X-Received: by 2002:a17:90b:1e05:: with SMTP id pg5mr10730059pjb.173.1634094421194; Tue, 12 Oct 2021 20:07:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyAEOaTQBzAI1dUfTgWthY9LXxK8kwJ8csIS2Ux71iJLJM8lfWL0zdJifDKCfMEE6bwiFFPQ== X-Received: by 2002:a17:90b:1e05:: with SMTP id pg5mr10730019pjb.173.1634094420827; Tue, 12 Oct 2021 20:07:00 -0700 (PDT) Received: from t490s ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id a17sm12770682pfd.54.2021.10.12.20.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 20:07:00 -0700 (PDT) Date: Wed, 13 Oct 2021 11:06:53 +0800 From: Peter Xu To: Yang Shi Cc: HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+jIOebtOS5nyk=?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Subject: Re: [v3 PATCH 4/5] mm: shmem: don't truncate page if memory failure happens Message-ID: References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-5-shy828301@gmail.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 315C97001A08 X-Stat-Signature: 3f5zeaqm743oooafp735z6wwy3r9a6pd Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ShdIwe4Q; spf=none (imf02.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam06 X-HE-Tag: 1634094426-877174 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 12, 2021 at 08:00:31PM -0700, Yang Shi wrote: > The page refcount could stop collapsing hwpoison page. One could argue > khugepaged could bail out earlier by checking hwpoison flag, but it is > definitely not a must do. So it relies on refcount now. I suppose you mean the page_ref_freeze() in collapse_file()? Yeah that seems to work too. Thanks, -- Peter Xu