From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57657C433F5 for ; Tue, 12 Oct 2021 19:12:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E165E60EDF for ; Tue, 12 Oct 2021 19:12:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E165E60EDF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 51B74900003; Tue, 12 Oct 2021 15:12:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CA50900002; Tue, 12 Oct 2021 15:12:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36B55900003; Tue, 12 Oct 2021 15:12:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id 28E4F900002 for ; Tue, 12 Oct 2021 15:12:42 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E22EA1839E10C for ; Tue, 12 Oct 2021 19:12:41 +0000 (UTC) X-FDA: 78688732122.24.7A882AA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id 91B1E9000390 for ; Tue, 12 Oct 2021 19:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DGWkbX/ZaEgRg7DRsLzrp9kIM60erHIxN+TZn8qPeGQ=; b=jufBdZSxirHSMU+jB+dOMAAzhO W5IV8MgdAw4khwIx6y6ygsZtrLZwKJVRD4JEtjwZLgaXvJ897DXP/epRStK+/+ovfOX0G919Brkr/ x5gvSmZlPhvSdgqPj0NJgInaCNMA22qr8ULAI/bxEUattTNuOlZVeIAyrTfylH/izyBdUk04R5u7X bI9kqHFIPtbYyHxIX8xVXyBGOYpkKQ0C9dPtgzcGbroNxx4W2GN9MyPi/yKdOPcjNydxglA9ZHKyZ ZKo16MMcvtZKxBiEtOhc3LWdcpfJ1dM6yOuPHZnomIpMHDCRLjThDNZNlDtjfEdN4WjxxN5RdLD8Z bv4uqz0A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1maNBC-006lpm-KI; Tue, 12 Oct 2021 19:11:36 +0000 Date: Tue, 12 Oct 2021 20:11:14 +0100 From: Matthew Wilcox To: Andrew Morton Cc: Alex Sierra , Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com, apopple@nvidia.com Subject: Re: [PATCH v1 00/12] MEMORY_DEVICE_COHERENT for CPU-accessible coherent device memory Message-ID: References: <20211012171247.2861-1-alex.sierra@amd.com> <20211012113957.53f05928dd60f3686331fede@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211012113957.53f05928dd60f3686331fede@linux-foundation.org> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 91B1E9000390 X-Stat-Signature: 4dt6yenc8by1qbimk54rhn5rrebsgypd Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jufBdZSx; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1634065960-433979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 12, 2021 at 11:39:57AM -0700, Andrew Morton wrote: > Because I must ask: if this feature is for one single computer which > presumably has a custom kernel, why add it to mainline Linux? I think in particular patch 2 deserves to be merged because it removes a ton of cruft from every call to put_page() (at least if you're using a distro config). It makes me nervous, but I think it's the right thing to do. It may well need more fixups after it has been merged, but that's life.