From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F93C433F5 for ; Mon, 11 Oct 2021 22:57:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC2A860E9C for ; Mon, 11 Oct 2021 22:57:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC2A860E9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4F5196B006C; Mon, 11 Oct 2021 18:57:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A532900003; Mon, 11 Oct 2021 18:57:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 392866B0074; Mon, 11 Oct 2021 18:57:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 25E456B006C for ; Mon, 11 Oct 2021 18:57:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DE205182C3812 for ; Mon, 11 Oct 2021 22:57:31 +0000 (UTC) X-FDA: 78685669902.01.963D48A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 5D4F030008F9 for ; Mon, 11 Oct 2021 22:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633993050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qXN/vzdwnclocStV3rAgvMW+lzmIwxCoY9r4CfSlUdw=; b=E3D1x81cl7M0sh2F7gDa3Ik0oCuuW+z7REE7gjLd5hsM6ULeJajfDn+ep1qK+f99JJt0J4 11CLNUxWWmZCrBIWTfB+BgkOPAC8BKSdzrCwmrzbDrgkfunJqkw3dLPMSOzclg21kvpJzA 9y8oNbfCEYvy1xHBqaC+nW/7JJKHsbM= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-ZBKRV_1lNZyiD0lU6-b8_Q-1; Mon, 11 Oct 2021 18:57:28 -0400 X-MC-Unique: ZBKRV_1lNZyiD0lU6-b8_Q-1 Received: by mail-pf1-f199.google.com with SMTP id t79-20020a627852000000b0044d0ecd9f7aso2224710pfc.13 for ; Mon, 11 Oct 2021 15:57:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qXN/vzdwnclocStV3rAgvMW+lzmIwxCoY9r4CfSlUdw=; b=DjyeS6Yqz2K4ZkdPvF2ddYiEztrKKXBPtmOV23xpPGolhnfG2VFv0mrk+ag5zjwTGJ 7AJR/gb/Ycj1iFRsQGc9MwczTSgIpwwpF9EW1P9U9FxgK9kRjxIDHgoHhMZ9mqER0Y8y vos6Ba1pjZn7F43HWrEAplc8SJdOe/2N16bLKVqdnLVCKnYYwpGA79g6oOd7s34QksFy jUzVJLmWZ7h0uwgA7Yfp809Ar7WtSPCb4iSdIfAb1wILfh+xf777zZoHrEbgUcELg9Zl 1wGduatUkEIjbKzfhC80ElFJ1VlFLmPEZukGd11DlwBDAN5hpeKBebvmh6ScOf+Qy0S1 zXpg== X-Gm-Message-State: AOAM533salG8BmL5tcN9p5G8Tc20IQdOSthhco3Q2pyCDRxQf2YaxlGJ 8skmD7OvtSq8ErPrCtWMfISwHR2eyuAplb7KuY/iHnYsTMI/cW1wioJ/tw+t2yYZ9fwsgiYbPBU xcMwHAT6r2pc= X-Received: by 2002:a17:903:22cc:b0:13e:fa73:6fef with SMTP id y12-20020a17090322cc00b0013efa736fefmr27329634plg.25.1633993046989; Mon, 11 Oct 2021 15:57:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7tlCmjti8dDtX3s90mHbpNajYA411v7qqZAafpSxBDhxylbZeGvAJU/eVUmaUhZ21fDfU6w== X-Received: by 2002:a17:903:22cc:b0:13e:fa73:6fef with SMTP id y12-20020a17090322cc00b0013efa736fefmr27329611plg.25.1633993046632; Mon, 11 Oct 2021 15:57:26 -0700 (PDT) Received: from t490s ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id k190sm8664644pfd.211.2021.10.11.15.57.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 15:57:25 -0700 (PDT) Date: Mon, 11 Oct 2021 18:57:18 -0400 From: Peter Xu To: "Kirill A. Shutemov" Cc: Yang Shi , HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+jIOebtOS5nyk=?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Subject: Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault Message-ID: References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-3-shy828301@gmail.com> <20211004140637.qejvenbkmrulqdno@box.shutemov.name> <20211004194130.6hdzanjl2e2np4we@box.shutemov.name> <20211008093529.sb54gnlbhuiy6klr@box.shutemov.name> MIME-Version: 1.0 In-Reply-To: <20211008093529.sb54gnlbhuiy6klr@box.shutemov.name> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5D4F030008F9 X-Stat-Signature: uneg4c3d4ihw98zrya4zpzd4bjpsuazm Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E3D1x81c; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf09.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=peterx@redhat.com X-HE-Tag: 1633993051-980979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 08, 2021 at 12:35:29PM +0300, Kirill A. Shutemov wrote: > JFYI, git blame -w ignores whitespace changes :P Thanks, Kirill. :) I must confess in reality I didn't encounter white-space changes a lot, but mostly on moving the code around either e.g. by putting things into, or out of, "if/for" blocks, or moving code between files. I used git-blame a lot not to looking for people to blame but to dig history of code changes, not sure about how others do that. So maybe it's just that I didn't do it right beforfe, and I'll be more than glad to learn if there's more tricks like the "-w" one (which I don't know before..). -- Peter Xu