From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C84C433EF for ; Tue, 12 Oct 2021 03:00:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB7A260698 for ; Tue, 12 Oct 2021 03:00:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB7A260698 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2844B6B006C; Mon, 11 Oct 2021 23:00:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 234806B0071; Mon, 11 Oct 2021 23:00:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D48D6B0073; Mon, 11 Oct 2021 23:00:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0234.hostedemail.com [216.40.44.234]) by kanga.kvack.org (Postfix) with ESMTP id F18716B006C for ; Mon, 11 Oct 2021 23:00:17 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 992042FD95 for ; Tue, 12 Oct 2021 03:00:17 +0000 (UTC) X-FDA: 78686281674.26.F7112E9 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf19.hostedemail.com (Postfix) with ESMTP id 2B776B002440 for ; Tue, 12 Oct 2021 03:00:17 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id p4so18259077qki.3 for ; Mon, 11 Oct 2021 20:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B100TNfxux8MkM53tT5+mvaB4zQgc5l0a51qWAB7oeY=; b=QcUrE/rGjmVLgGRtI564GAlFVUpY0c99OGdEyNr1y0rX8/wuU4xUpFvLhvh7ge20YA VjENDJ9PEOv9K8PKAAOKpo8KrEOXAdyFcqMMJ0ochkvA6vqnmy/gcKqb2ZQnKRvvPQvJ T4hoYsaapC11TwiL++jziZS8g9wXYA3tSvryZI0Yve32gs00DWtQ4tEruIL/csN1VEfs /woymrea9zjZQm9NvjuthLP1v82wrZY/WbjveZw6bTW9llxYFVJDV5v5KRP4cZekrk33 o03hHS31unp49DwnOwHbjQ2dIYZx3iK2UDKV3x+lDJwiPpwGdi46I4t78jM4JVKyRVwj Msmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B100TNfxux8MkM53tT5+mvaB4zQgc5l0a51qWAB7oeY=; b=yRTMvj87o6U+nnYBynBwt5m6ZYzETU9fGyeQq2cPuhPJPfQAJ7loWjP8qEWlhHKIy9 6NSEAjJQQfFF2PueQBdhRVrjJSZ9AzrzCW1fbXOq3EkwA5hKcwszyrFJW5gJ212fixVL Syn8nBpycaRYMU8uJcLr8TvUnbdWnHfeERkm3geowIJV+LZu+D8xneGoRGU2XXIuotCk DTLov6lVPnwCZljiQqgGT8AkkObG3Jk2Zag6iwP/JhB14FsLjOBw3O1HaZxpPMlxghXq 4P2ee8g9PE4+/3sM0brgXPe8XKC/TwO7cJltLiAJuxYkUmf3eHvAnntJMzanCm9os7B5 dRBA== X-Gm-Message-State: AOAM533K68MSUeEiiLt75KotQmsyGiRdcl6bTI5STBhDNlXDlH1YEZY7 GickkbzKJOF7S7yBteaLUr9zRA== X-Google-Smtp-Source: ABdhPJyA16KHuJMlpHIfDt8HoA0n9/NzYG93r2bEkIaMUlRRltkLlZ5fuYvSCm7pvSgA1xkD8SVDtQ== X-Received: by 2002:a37:a748:: with SMTP id q69mr17559785qke.178.1634007616296; Mon, 11 Oct 2021 20:00:16 -0700 (PDT) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id 9sm5174953qkn.84.2021.10.11.20.00.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 20:00:15 -0700 (PDT) Date: Mon, 11 Oct 2021 23:00:14 -0400 From: Johannes Weiner To: Suren Baghdasaryan Cc: Michal Hocko , Kees Cook , Pavel Machek , Rasmus Villemoes , David Hildenbrand , John Hubbard , Andrew Morton , Colin Cross , Sumit Semwal , Dave Hansen , Matthew Wilcox , "Kirill A . Shutemov" , Vlastimil Babka , Jonathan Corbet , Al Viro , Randy Dunlap , Kalesh Singh , Peter Xu , rppt@kernel.org, Peter Zijlstra , Catalin Marinas , vincenzo.frascino@arm.com, Chinwen Chang =?utf-8?B?KOW8temMpuaWhyk=?= , Axel Rasmussen , Andrea Arcangeli , Jann Horn , apopple@nvidia.com, Yu Zhao , Will Deacon , fenghua.yu@intel.com, thunder.leizhen@huawei.com, Hugh Dickins , feng.tang@intel.com, Jason Gunthorpe , Roman Gushchin , Thomas Gleixner , krisman@collabora.com, Chris Hyser , Peter Collingbourne , "Eric W. Biederman" , Jens Axboe , legion@kernel.org, Rolf Eike Beer , Cyrill Gorcunov , Muchun Song , Viresh Kumar , Thomas Cedeno , sashal@kernel.org, cxfcosmos@gmail.com, LKML , linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm , kernel-team , Tim Murray Subject: Re: [PATCH v10 3/3] mm: add anonymous vma name refcounting Message-ID: References: <202110071111.DF87B4EE3@keescook> <202110081344.FE6A7A82@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2B776B002440 X-Stat-Signature: m6dw5k3dcwzcqzcjtj1ime9cr6yaiz5j Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b="QcUrE/rG"; spf=pass (imf19.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-Rspamd-Server: rspam06 X-HE-Tag: 1634007617-455328 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 11, 2021 at 06:20:25PM -0700, Suren Baghdasaryan wrote: > On Mon, Oct 11, 2021 at 6:18 PM Suren Baghdasaryan wrote: > > > > On Mon, Oct 11, 2021 at 1:36 AM Michal Hocko wrote: > > > > > > On Fri 08-10-21 13:58:01, Kees Cook wrote: > > > > - Strings for "anon" specifically have no required format (this is good) > > > > it's informational like the task_struct::comm and can (roughly) > > > > anything. There's no naming convention for memfds, AF_UNIX, etc. Why > > > > is one needed here? That seems like a completely unreasonable > > > > requirement. > > > > > > I might be misreading the justification for the feature. Patch 2 is > > > talking about tools that need to understand memeory usage to make > > > further actions. Also Suren was suggesting "numbering convetion" as an > > > argument against. > > > > > > So can we get a clear example how is this being used actually? If this > > > is just to be used to debug by humans than I can see an argument for > > > human readable form. If this is, however, meant to be used by tools to > > > make some actions then the argument for strings is much weaker. > > > > The simplest usecase is when we notice that a process consumes more > > memory than usual and we do "cat /proc/$(pidof my_process)/maps" to > > check which area is contributing to this growth. The names we assign > > to anonymous areas are descriptive enough for a developer to get an > > idea where the increased consumption is coming from and how to proceed > > with their investigation. > > There are of course cases when tools are involved, but the end-user is > > always a human and the final report should contain easily > > understandable data. > > > > IIUC, the main argument here is whether the userspace can provide > > tools to perform the translations between ids and names, with the > > kernel accepting and reporting ids instead of strings. Technically > > it's possible, but to be practical that conversion should be fast > > because we will need to make name->id conversion potentially for each > > mmap. On the consumer side the performance is not as critical, but the > > fact that instead of dumping /proc/$pid/maps we will have to parse the > > file, do id->name conversion and replace all [anon:id] with > > [anon:name] would be an issue when we do that in bulk, for example > > when collecting system-wide data for a bugreport. Is that something you need to do client-side? Or could the bug tool upload the userspace-maintained name:ids database alongside the /proc/pid/maps dump for external processing?