linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.com>
To: David Hildenbrand <david@redhat.com>
Cc: ultrachin@163.com, akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, brookxu.cn@gmail.com,
	chen xiaoguang <xiaoggchen@tencent.com>,
	zeng jingxiang <linuszeng@tencent.com>,
	lu yihui <yihuilu@tencent.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Daniel Jordan <daniel.m.jordan@oracle.com>
Subject: Re: [PATCH] mm: Free per cpu pages async to shorten program exit time
Date: Mon, 11 Oct 2021 13:23:00 +0200	[thread overview]
Message-ID: <YWQelNijZQ7PuYSa@dhcp22.suse.cz> (raw)
In-Reply-To: <278a6cda-3095-5e27-e136-2765f73bc67d@redhat.com>

On Mon 11-10-21 11:40:12, David Hildenbrand wrote:
> On 11.10.21 11:28, Michal Hocko wrote:
> > On Fri 08-10-21 10:17:50, David Hildenbrand wrote:
> > > On 08.10.21 08:39, ultrachin@163.com wrote:
> > > > From: chen xiaoguang <xiaoggchen@tencent.com>
> > > > 
> > > > The exit time is long when program allocated big memory and
> > > > the most time consuming part is free memory which takes 99.9%
> > > > of the total exit time. By using async free we can save 25% of
> > > > exit time.
> > > > 
> > > > Signed-off-by: chen xiaoguang <xiaoggchen@tencent.com>
> > > > Signed-off-by: zeng jingxiang <linuszeng@tencent.com>
> > > > Signed-off-by: lu yihui <yihuilu@tencent.com>
> > > 
> > > I recently discussed with Claudio if it would be possible to tear down the
> > > process MM deferred, because for some use cases (secure/encrypted
> > > virtualization, very large mmaps) tearing down the page tables is already
> > > the much more expensive operation.
> > > 
> > > There is mmdrop_async(), and I wondered if one could reuse that concept when
> > > tearing down a process -- I didn't look into feasibility, however, so it's
> > > just some very rough idea.
> > 
> > This is not a new problem. Large process tear down can take ages. The
> > primary road block has been accounting. This lot of work has to be
> > accounted to the proper domain (e.g. cpu cgroup).
> 
> In general, yes. For some setups where admins don't care about that
> accounting (e.g., enabled via some magic toggle for large VMs), I guess this
> accounting isn't the major roadblock, correct?

Right, I would be careful about magic toggles though. Besides there are
ways to achive this in the userspace. We used to have a request to help
paralleling process exit from a DB vendor and Vlastimil has come up with
a clone(CLONE_VM) and madvise(DONT_NEED) from several threads as a
"workaround". This would work properly from the accounting POV.
Admittedly a bit of an involved approach though.
-- 
Michal Hocko
SUSE Labs


  reply	other threads:[~2021-10-11 11:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211008063933.331989-1-ultrachin@163.com>
2021-10-08  8:17 ` David Hildenbrand
2021-10-08  8:52   ` Claudio Imbrenda
2021-10-08  9:15     ` David Hildenbrand
2021-10-08  9:22       ` Claudio Imbrenda
2021-10-08  9:24         ` David Hildenbrand
2021-10-08 12:38   ` Vlastimil Babka
2021-10-08 12:54     ` Claudio Imbrenda
2021-10-08 12:55     ` David Hildenbrand
2021-10-10 22:42     ` Andrew Morton
2021-10-11  9:28   ` Michal Hocko
2021-10-11  9:40     ` David Hildenbrand
2021-10-11 11:23       ` Michal Hocko [this message]
2021-10-13 17:38     ` Daniel Jordan
2021-10-08 11:27 ` kernel test robot
2021-10-08 12:29 ` kernel test robot
2021-10-11  8:20 ` [mm] 3e55b36596: kernel_BUG_at_mm/page_alloc.c kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YWQelNijZQ7PuYSa@dhcp22.suse.cz \
    --to=mhocko@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=brookxu.cn@gmail.com \
    --cc=daniel.m.jordan@oracle.com \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=linuszeng@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ultrachin@163.com \
    --cc=xiaoggchen@tencent.com \
    --cc=yihuilu@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox