From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C53C6C433EF for ; Tue, 19 Oct 2021 08:55:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 712DB6115A for ; Tue, 19 Oct 2021 08:55:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 712DB6115A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0E9C46B006C; Tue, 19 Oct 2021 04:55:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09AD26B0071; Tue, 19 Oct 2021 04:55:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECBC1900002; Tue, 19 Oct 2021 04:55:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id DE33A6B006C for ; Tue, 19 Oct 2021 04:55:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 99E198249980 for ; Tue, 19 Oct 2021 08:55:44 +0000 (UTC) X-FDA: 78712579008.03.3B047B1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id 3DF5210400E1 for ; Tue, 19 Oct 2021 08:55:41 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 0717221976; Tue, 19 Oct 2021 08:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1634633743; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9RwzVBFGDFRteBRtUaexR2o4mqwWh6zXF3EufALmmMY=; b=dQqIxNFcfFg+sPk1JmTQ1nYBdSadedzTUdQ7cmmDplqweHL6D/vRExRJ/hfmCwAcaIyTJl 8DGp7M/Q8bDp9Hrqj0zBih55aVt+rLj+T7q5/A8SMEvmuQ8HE95ulnKB/o9Rvz3WCreST/ UOTaTB4NgxP9opPckBVds+4SGXHh41Q= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 54989A3B81; Tue, 19 Oct 2021 08:55:42 +0000 (UTC) Date: Tue, 19 Oct 2021 10:55:41 +0200 From: Michal Hocko To: Huangzhaoyang Cc: Andrew Morton , Johannes Weiner , Vladimir Davydov , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: skip current when memcg reclaim Message-ID: References: <1634628576-27448-1-git-send-email-huangzhaoyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1634628576-27448-1-git-send-email-huangzhaoyang@gmail.com> X-Stat-Signature: 5gmbp5swc8f3yrh6wd1fbxp3hmrew7ps Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=dQqIxNFc; spf=pass (imf13.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3DF5210400E1 X-HE-Tag: 1634633741-489124 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 19-10-21 15:29:36, Huangzhaoyang wrote: > From: Zhaoyang Huang > > Reclaiming pages from current LRU will introduce page thrashing during direct > reclaiming. Have all memory contraint groups steal pages from the processes > under root(Non-memory sensitive) or other groups with lower thresholds(high > memory tolerance) or the one totally sleeping(not busy for the time being, > borrow some pages).With regard to all groups trapping into direct reclaim, > retry if first round failed and all groups still compete fairly. > > Signed-off-by: Zhaoyang Huang > --- > patch v2: grant current second chance if previous reclaiming failed It would be really better to wait until a discussion around the previous version is concluded before posting another one. Btw. this changelog has some serious gaps in both the problem and solution description. Please spend some time looking at other changelogs for MM patches to get some idea about the level of details that we usually require. Thanks! -- Michal Hocko SUSE Labs