From: Michal Hocko <mhocko@suse.com>
To: Huangzhaoyang <huangzhaoyang@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: skip current when memcg reclaim
Date: Tue, 19 Oct 2021 10:55:41 +0200 [thread overview]
Message-ID: <YW6IDchljdzbxvDU@dhcp22.suse.cz> (raw)
In-Reply-To: <1634628576-27448-1-git-send-email-huangzhaoyang@gmail.com>
On Tue 19-10-21 15:29:36, Huangzhaoyang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>
> Reclaiming pages from current LRU will introduce page thrashing during direct
> reclaiming. Have all memory contraint groups steal pages from the processes
> under root(Non-memory sensitive) or other groups with lower thresholds(high
> memory tolerance) or the one totally sleeping(not busy for the time being,
> borrow some pages).With regard to all groups trapping into direct reclaim,
> retry if first round failed and all groups still compete fairly.
>
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> ---
> patch v2: grant current second chance if previous reclaiming failed
It would be really better to wait until a discussion around the previous
version is concluded before posting another one.
Btw. this changelog has some serious gaps in both the problem and
solution description. Please spend some time looking at other changelogs
for MM patches to get some idea about the level of details that we
usually require.
Thanks!
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2021-10-19 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 7:29 Huangzhaoyang
2021-10-19 8:55 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW6IDchljdzbxvDU@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=huangzhaoyang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox