From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAA42C433FE for ; Mon, 18 Oct 2021 16:51:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7095A60FC2 for ; Mon, 18 Oct 2021 16:51:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7095A60FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0B6F9900003; Mon, 18 Oct 2021 12:51:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0663C900002; Mon, 18 Oct 2021 12:51:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E968F900003; Mon, 18 Oct 2021 12:51:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id DC611900002 for ; Mon, 18 Oct 2021 12:51:26 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6B9C831EB4 for ; Mon, 18 Oct 2021 16:51:26 +0000 (UTC) X-FDA: 78710148972.05.7C295AA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf24.hostedemail.com (Postfix) with ESMTP id DE829B0000A6 for ; Mon, 18 Oct 2021 16:51:23 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1406121966; Mon, 18 Oct 2021 16:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1634575885; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6d1q+ubZusaXumuE3riMUHm2jTbTP959W22zG60KItg=; b=fKu+qOYXhZzEp+4Webr7Gz5rjCvBK4A8tlusIDpeSd3E8XdtJaNxr8PAFbK6W9yO+rJ8pN oVQLPo5TxdQHL4pK+LLbCl4u0Z1E4/d/0cwHIYBJh+eMmFEbE4ldAJ0nwZHCPEYUZBx6J/ E8Tohc07y3OCyC2sRGMX3CMeUir1HFw= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C44B3A3B83; Mon, 18 Oct 2021 16:51:24 +0000 (UTC) Date: Mon, 18 Oct 2021 18:51:24 +0200 From: Michal Hocko To: Shakeel Butt Cc: Vasily Averin , Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Uladzislau Rezki , Vlastimil Babka , Mel Gorman , Cgroups , Linux MM , LKML , kernel@openvz.org Subject: Re: [PATCH memcg 0/1] false global OOM triggered by memcg-limited task Message-ID: References: <9d10df01-0127-fb40-81c3-cc53c9733c3e@virtuozzo.com> <6b751abe-aa52-d1d8-2631-ec471975cc3a@virtuozzo.com> <27dc0c49-a0d6-875b-49c6-0ef5c0cc3ac8@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: DE829B0000A6 X-Stat-Signature: ccncjioyndxrzwx65bzx3qp1zfrgyoz7 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=fKu+qOYX; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf24.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com X-Rspamd-Server: rspam02 X-HE-Tag: 1634575883-779956 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 18-10-21 08:07:20, Shakeel Butt wrote: > On Mon, Oct 18, 2021 at 5:27 AM Michal Hocko wrote: > > > > [restore the cc list] > > > > On Mon 18-10-21 15:14:26, Vasily Averin wrote: > > > On 18.10.2021 14:53, Michal Hocko wrote: > > > > On Mon 18-10-21 13:05:35, Vasily Averin wrote: > > > >> On 18.10.2021 12:04, Michal Hocko wrote: > > > >> Here we call try_charge_memcg() that return success and approve the allocation, > > > >> however then we hit into kmem limit and fail the allocation. > > > > > > > > Just to make sure I understand this would be for the v1 kmem explicit > > > > limit, correct? > > > > > > yes, I mean this limit. > > > > OK, thanks for the clarification. This is a known problem. Have a look > > at I think we consider that one to 0158115f702b ("memcg, kmem: deprecate > > kmem.limit_in_bytes"). We are reporting the deprecated and to-be removed > > status since 2019 without any actual report sugested by the kernel > > message. Maybe we should try and remove it and see whether that prompts > > some pushback. > > > > Yes, I think now should be the right time to take the next step for > deprecation of kmem limits: > https://lore.kernel.org/all/20201118175726.2453120-1-shakeelb@google.com/ I completely forgot about your patch. Anyway, it usually takes us years to deprecate something so let's stick with it and consider 2 years as years ;) -- Michal Hocko SUSE Labs