From: Michal Hocko <mhocko@suse.com>
To: Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: skip current when memcg reclaim
Date: Wed, 20 Oct 2021 10:55:27 +0200 [thread overview]
Message-ID: <YW/Zf/s/CtRFlJ87@dhcp22.suse.cz> (raw)
In-Reply-To: <CAGWkznGb05Uykxz=9K+8uB6axS7LCo_7hMXAn7DFJXvAmkFy5Q@mail.gmail.com>
On Wed 20-10-21 15:33:39, Zhaoyang Huang wrote:
[...]
> Do you mean that direct reclaim should succeed for the first round
> reclaim within which memcg get protected by memory.low and would NOT
> retry by setting memcg_low_reclaim to true?
Yes, this is the semantic of low limit protection in the upstream
kernel. Have a look at do_try_to_free_pages and how it sets
memcg_low_reclaim only if there were no pages reclaimed.
> It is not true in android
> like system, where reclaim always failed and introduce lmk and even
> OOM.
I am not familiar with android specific changes to the upstream reclaim
logic. You should be investigating why the reclaim couldn't make a
forward progress (aka reclaim pages) from non-protected memcgs. There
are tracepoints you can use (generally vmscan prefix).
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-10-20 8:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 6:15 Huangzhaoyang
2021-10-15 20:00 ` Andrew Morton
2021-10-16 2:28 ` Zhaoyang Huang
2021-10-16 2:58 ` Andrew Morton
2021-10-16 3:05 ` Matthew Wilcox
2021-10-16 8:17 ` Zhaoyang Huang
2021-10-18 8:23 ` Michal Hocko
2021-10-18 9:25 ` Zhaoyang Huang
2021-10-18 12:41 ` Michal Hocko
2021-10-19 7:11 ` Zhaoyang Huang
2021-10-19 9:09 ` Michal Hocko
2021-10-19 12:17 ` Zhaoyang Huang
2021-10-19 13:23 ` Michal Hocko
2021-10-20 7:33 ` Zhaoyang Huang
2021-10-20 8:55 ` Michal Hocko [this message]
2021-10-20 11:45 ` Zhaoyang Huang
2021-10-20 15:11 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW/Zf/s/CtRFlJ87@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=huangzhaoyang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vdavydov.dev@gmail.com \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox