From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35CE6C433EF for ; Sun, 3 Oct 2021 06:04:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C853B61B23 for ; Sun, 3 Oct 2021 06:04:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C853B61B23 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 06A976B006C; Sun, 3 Oct 2021 02:04:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 019E96B0071; Sun, 3 Oct 2021 02:04:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4AE3900002; Sun, 3 Oct 2021 02:04:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id D53656B006C for ; Sun, 3 Oct 2021 02:04:04 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7AB2E8249980 for ; Sun, 3 Oct 2021 06:04:04 +0000 (UTC) X-FDA: 78654085608.05.CF2A676 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP id 241BF9002BC3 for ; Sun, 3 Oct 2021 06:04:04 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id CC61C61872; Sun, 3 Oct 2021 06:04:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633241043; bh=GMxcFw+H5zCy90UDkXRSw9WX9TSeYQZzDe7rSV/Tr5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hTo8hU0HPBQedF/3L7QqO312UYzIQX1cvjyoNS8oeYshI0Y5+hEeiWVK1myHFQ+Eu hV19bP4CCYRP/uMsbJfLjknJT1ZT6bMsxMvBKRzKZ28Qo/+tKIyca6liApCUG6M6OL fN5sPatG81hS7Y2QXV/QUtkb/643UfergAs8mRUItCrt2BcNwIDI70s4o9K/XcDeVc 8BC/C/25BFcHM5Z4CAx3ZznW3sN/gwEY1TPTSUdeubzRSqBYeIhzgjrSkx4gKc+z2V TYRbM16EnQXivfISYuRrtwNcbi0o+NoBCDDSz8aD5YkOq2UOWQGvlykGLJ3KtzIOWw KKej39z+PzGdg== Date: Sat, 2 Oct 2021 23:03:55 -0700 From: Mike Rapoport To: Joe Perches Cc: Andrew Morton , linux-mm , LKML Subject: Re: [PATCH] memblock: Neaten logging Message-ID: References: <623750dd31aa3fe5e45c416be98ab37707e2c45d.camel@perches.com> <6573ccd25ce80f5e28ed35e4c88c898b0f994fbc.camel@perches.com> <06ede4d0c1bf66614c9e9e013098a876aeec883f.camel@perches.com> <7c9103aee37509a28e426756bce7d6a5ae0ced16.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c9103aee37509a28e426756bce7d6a5ae0ced16.camel@perches.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 241BF9002BC3 X-Stat-Signature: eowmzzewf3tqh8dh8ftm83p9qu5rawyd Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hTo8hU0H; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-HE-Tag: 1633241044-728620 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 01, 2021 at 04:20:14PM -0700, Joe Perches wrote: > On Fri, 2021-10-01 at 16:12 -0700, Mike Rapoport wrote: > > On Fri, Oct 01, 2021 at 01:34:10PM -0700, Joe Perches wrote: > > > On Fri, 2021-10-01 at 09:37 -0700, Mike Rapoport wrote: > > > > On Thu, Sep 30, 2021 at 06:27:15PM -0700, Joe Perches wrote: > > > > > On Thu, 2021-09-30 at 14:12 -0700, Mike Rapoport wrote: > > > > > > Hi Joe, > > > > > > > > > > > > On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote: > > > > > > > Use more typical kernel logging styles. > > > > > > > > > > > > > > o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt > > > > > > > > > > > > I don't see it as an improvement. On the contrary, the output becomes > > > > > > somewhat tautological: > > > > > > > > > > And rather easier to grep as the prefix is constant. > > > > > > > > memblock_ is perfectly greppable > > > > > > Of course, but only when it's there, 2 instances out of 9. > > > > I didn't object to the patch as a whole. I just don't like the pr_fmt > > definition. > > You should do what you like. I did what I like. I'm perfectly fine with the current state. -- Sincerely yours, Mike.