From: Mike Rapoport <rppt@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memblock: Neaten logging
Date: Sat, 2 Oct 2021 23:03:55 -0700 [thread overview]
Message-ID: <YVlHy7kL1MKZaH6C@kernel.org> (raw)
In-Reply-To: <7c9103aee37509a28e426756bce7d6a5ae0ced16.camel@perches.com>
On Fri, Oct 01, 2021 at 04:20:14PM -0700, Joe Perches wrote:
> On Fri, 2021-10-01 at 16:12 -0700, Mike Rapoport wrote:
> > On Fri, Oct 01, 2021 at 01:34:10PM -0700, Joe Perches wrote:
> > > On Fri, 2021-10-01 at 09:37 -0700, Mike Rapoport wrote:
> > > > On Thu, Sep 30, 2021 at 06:27:15PM -0700, Joe Perches wrote:
> > > > > On Thu, 2021-09-30 at 14:12 -0700, Mike Rapoport wrote:
> > > > > > Hi Joe,
> > > > > >
> > > > > > On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote:
> > > > > > > Use more typical kernel logging styles.
> > > > > > >
> > > > > > > o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt
> > > > > >
> > > > > > I don't see it as an improvement. On the contrary, the output becomes
> > > > > > somewhat tautological:
> > > > >
> > > > > And rather easier to grep as the prefix is constant.
> > > >
> > > > memblock_ is perfectly greppable
> > >
> > > Of course, but only when it's there, 2 instances out of 9.
> >
> > I didn't object to the patch as a whole. I just don't like the pr_fmt
> > definition.
>
> You should do what you like. I did what I like.
I'm perfectly fine with the current state.
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2021-10-03 6:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 4:43 Joe Perches
2021-09-30 21:12 ` Mike Rapoport
2021-10-01 1:27 ` Joe Perches
2021-10-01 16:37 ` Mike Rapoport
2021-10-01 20:34 ` Joe Perches
2021-10-01 23:12 ` Mike Rapoport
2021-10-01 23:20 ` Joe Perches
2021-10-03 6:03 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVlHy7kL1MKZaH6C@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox