From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80C01C433FE for ; Fri, 1 Oct 2021 23:12:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2673D61A3A for ; Fri, 1 Oct 2021 23:12:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2673D61A3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B1B79940157; Fri, 1 Oct 2021 19:12:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACBA3940121; Fri, 1 Oct 2021 19:12:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BAFC940157; Fri, 1 Oct 2021 19:12:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 8BB3D940121 for ; Fri, 1 Oct 2021 19:12:09 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4618A8249980 for ; Fri, 1 Oct 2021 23:12:09 +0000 (UTC) X-FDA: 78649418778.19.A0DA555 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP id EB0B56001987 for ; Fri, 1 Oct 2021 23:12:08 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 97D1E61A56; Fri, 1 Oct 2021 23:12:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633129926; bh=zXrRFKYFnzDxZpyFAhZ2wpdjQvNuybBFe1IPJSuaa68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fYmNRF74XZxBmlqjGgKWDIrgfg9KxKGnnkE1wwh/3WzmmEY+FuMgA78aVn6pQTpcD kY2c7m0r3p9UtBGBYHyCt3SZPRWTEgO8xgMpy3h/hAVRZv0Y1QRF1KKglkQLX69LxP Lz45hgAMzqsuFMblCoSq0cbHCLHl5o28JEdU8WVvYuQblHw/lETlC35WgGck2owN/G PMYfGU7keSJIzK+cS0eW5wwY50D48snRa4Lp/yX5lw/j3KPDfaDJRH5xfrhIAMv2QT y5AcSDBrOqcW+wCWrjakq1p7xOFLFT2apdqInjDNVYXX4Qn9VVWICv0WHOXc5UJtN0 KxFHnGsfa6VEA== Date: Fri, 1 Oct 2021 16:12:00 -0700 From: Mike Rapoport To: Joe Perches Cc: Andrew Morton , linux-mm , LKML Subject: Re: [PATCH] memblock: Neaten logging Message-ID: References: <623750dd31aa3fe5e45c416be98ab37707e2c45d.camel@perches.com> <6573ccd25ce80f5e28ed35e4c88c898b0f994fbc.camel@perches.com> <06ede4d0c1bf66614c9e9e013098a876aeec883f.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <06ede4d0c1bf66614c9e9e013098a876aeec883f.camel@perches.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EB0B56001987 X-Stat-Signature: tg95fu3f9ogjbodn4iij5uxod6ctmfgt Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fYmNRF74; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-HE-Tag: 1633129928-339794 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 01, 2021 at 01:34:10PM -0700, Joe Perches wrote: > On Fri, 2021-10-01 at 09:37 -0700, Mike Rapoport wrote: > > On Thu, Sep 30, 2021 at 06:27:15PM -0700, Joe Perches wrote: > > > On Thu, 2021-09-30 at 14:12 -0700, Mike Rapoport wrote: > > > > Hi Joe, > > > > > > > > On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote: > > > > > Use more typical kernel logging styles. > > > > > > > > > > o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt > > > > > > > > I don't see it as an improvement. On the contrary, the output becomes > > > > somewhat tautological: > > > > > > And rather easier to grep as the prefix is constant. > > > > memblock_ is perfectly greppable > > Of course, but only when it's there, 2 instances out of 9. I didn't object to the patch as a whole. I just don't like the pr_fmt definition. > $ git grep '\bpr_' mm/memblock.c > mm/memblock.c: pr_warn("Could not allocate %pap bytes of mirrored memory\n", > mm/memblock.c: pr_err("memblock: Failed to double %s array from %ld to %ld entries !\n", > mm/memblock.c: pr_warn("Could not allocate %pap bytes of mirrored memory\n", These can have %s for __func__ as a prefix, > mm/memblock.c: pr_warn("%s: No memory registered yet\n", __func__); this one already has it, > mm/memblock.c: pr_info(" %s.cnt = 0x%lx\n", type->name, type->cnt); > mm/memblock.c: pr_info(" %s[%#x]\t[%pa-%pa], %pa bytes%s flags: %#x\n", > mm/memblock.c: pr_info("MEMBLOCK configuration:\n"); > mm/memblock.c: pr_info(" memory size = %pa reserved size = %pa\n", and these are just fine now even without the prefix. -- Sincerely yours, Mike.