From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4656C433EF for ; Fri, 1 Oct 2021 14:27:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F93761A3A for ; Fri, 1 Oct 2021 14:27:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2F93761A3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 77493940112; Fri, 1 Oct 2021 10:27:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 724229400E4; Fri, 1 Oct 2021 10:27:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EC9D940112; Fri, 1 Oct 2021 10:27:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id 503A39400E4 for ; Fri, 1 Oct 2021 10:27:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 126123A2C9 for ; Fri, 1 Oct 2021 14:27:06 +0000 (UTC) X-FDA: 78648095652.12.79D3E38 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf24.hostedemail.com (Postfix) with ESMTP id BA2F5B000D5E for ; Fri, 1 Oct 2021 14:27:05 +0000 (UTC) Received: by mail-qk1-f175.google.com with SMTP id d207so9345388qkg.0 for ; Fri, 01 Oct 2021 07:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DJs75BQaCW/g7pooRRj+6YO0ULlwMz3u2sNV5tiA/bM=; b=12f9ZN14mCgZ+mea7F6AapeGsomq5b/qDbcNfxZe76D96JIWEGlDkLQclucjiNxCER Pykd8tU79SFQM8L6xrigX5TEUjdEKChTRdTwmB6OPH6gCCIU9NVtzIzu0eZLv3xkLHCV uNuuIADIN040sWB1WYlgO5d4s+YLUIqo0SfGu/I4iP50M63j6rHIsaNJn4PFAwznaq1C oa60iWCS7UzYVFhUk0swK39HZ94r8v6wFNilzivbnZoyQhJ6or+govTF2UC3OIbYVsts AiZN/0uso7kEG44pjbDzm/rw6Kkd0agK1pN7/arZvdjziYQwcNlNvR0PqWpFKylS7sco 0Ygw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DJs75BQaCW/g7pooRRj+6YO0ULlwMz3u2sNV5tiA/bM=; b=WSOPCK1sqD2oCNd+HrYCKkS91zq4EMslgflK3YbqUf/TAhYRNLnz0+rLIZnRkqp3ym VLc/gGrwQ48NCv3K8aPdQu6uIg+g91MqYAikz8208m01XL14xL5bFaJTAYJ1T3eYf3Mu MAbV+phI1eQu8NwHQpuozuGuAFXWHGcD2MBalQkYFKRvT0XoEikht1O/1i9VSA3Rj6O1 niQakjSJfMDJyT5l2zrwC5I4g2qQIU7sdo7GwE571ENHJ37neUlpVYa9qLynObrpd7wM /QYsHn3zc3vi4rQvQ34gYcqoKDVsN12zUuEzJhO4m6aRUtCOe7GGg4QdvJEvW1sar7t0 dqRw== X-Gm-Message-State: AOAM533r3Y1sVl/EtznEE+egO4Xu51vUVZxJwrRZY0nw3IILG8IJxH9y Xfvnf62HxySuWoKsldkrtEiyUA== X-Google-Smtp-Source: ABdhPJziQP96l0Jg2qQu8oA5s6SKXjOsig27Z/sQ8/zMDsRX8qxd3kRy/BxnffoUk1+5psaMOzNUYA== X-Received: by 2002:a37:8a47:: with SMTP id m68mr1684979qkd.452.1633098425018; Fri, 01 Oct 2021 07:27:05 -0700 (PDT) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id w17sm3085594qkf.97.2021.10.01.07.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Oct 2021 07:27:04 -0700 (PDT) Date: Fri, 1 Oct 2021 10:29:13 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Michal Hocko , Michal =?iso-8859-1?Q?Koutn=FD?= , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] memcg: unify memcg stat flushing Message-ID: References: <20210930044711.2892660-1-shakeelb@google.com> <20210930044711.2892660-2-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210930044711.2892660-2-shakeelb@google.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BA2F5B000D5E X-Stat-Signature: csdgr64u4eyubjaysj7wxh1jggbp3zr5 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=12f9ZN14; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf24.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.175 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org X-HE-Tag: 1633098425-264195 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 29, 2021 at 09:47:11PM -0700, Shakeel Butt wrote: > The memcg stats can be flushed in multiple context and potentially in > parallel too. For example multiple parallel user space readers for memcg > stats will contend on the rstat locks with each other. There is no need > for that. We just need one flusher and everyone else can benefit. In > addition after aa48e47e3906 ("memcg: infrastructure to flush memcg > stats") the kernel periodically flush the memcg stats from the root, so, > the other flushers will potentially have much less work to do. > > Signed-off-by: Shakeel Butt Acked-by: Johannes Weiner