From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC997C433F5 for ; Fri, 1 Oct 2021 16:37:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BBE661A56 for ; Fri, 1 Oct 2021 16:37:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7BBE661A56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B5277940117; Fri, 1 Oct 2021 12:37:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFF129400E4; Fri, 1 Oct 2021 12:37:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1575940117; Fri, 1 Oct 2021 12:37:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id 947FB9400E4 for ; Fri, 1 Oct 2021 12:37:28 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5049A8249980 for ; Fri, 1 Oct 2021 16:37:28 +0000 (UTC) X-FDA: 78648424176.22.4DCEDD2 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP id 03EA290003B0 for ; Fri, 1 Oct 2021 16:37:27 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0FD7E6109E; Fri, 1 Oct 2021 16:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633106247; bh=jrl2YhyHoUdaRTF3s8q4PJKPiBFPytXlEA9Ow6uY5ZY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SP9jYkGh8LJ08CdKPRYmKvO+U83FSCxVOQeT/wziT6XuSfam748q1B6Va9NhwadUq 51olSBOlhS0v3VMUSWy070PGh4jZZcaZW2ehPF/wGsTOzotKqK72rKUxaY01mAMyfa 8CEG+hXx2cabcyeAsHLguY3Wau2ZWwxB986XMOdv4sttRx26GuqHjXlB76Qp+C4rux tPQpyc7r32giGZDO6dZ33KbVP4qlA7icTwB0PLs3eneEgsT1hFVbjPxj0ikyrHjpPj pn39QBJZXRUz2zv88c6nMW2ngd3UOpK5e2UANhHS6Ni/NZlHKW+4ff5yoAP9x+/zzF RKnc/+/p9Z/JA== Date: Fri, 1 Oct 2021 09:37:25 -0700 From: Mike Rapoport To: Joe Perches Cc: Andrew Morton , linux-mm , LKML Subject: Re: [PATCH] memblock: Neaten logging Message-ID: References: <623750dd31aa3fe5e45c416be98ab37707e2c45d.camel@perches.com> <6573ccd25ce80f5e28ed35e4c88c898b0f994fbc.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6573ccd25ce80f5e28ed35e4c88c898b0f994fbc.camel@perches.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 03EA290003B0 X-Stat-Signature: h8gxxfzixh7toubkd7zmzsg5qqf9u7rp Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SP9jYkGh; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-HE-Tag: 1633106247-358168 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 30, 2021 at 06:27:15PM -0700, Joe Perches wrote: > On Thu, 2021-09-30 at 14:12 -0700, Mike Rapoport wrote: > > Hi Joe, > > > > On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote: > > > Use more typical kernel logging styles. > > > > > > o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt > > > > I don't see it as an improvement. On the contrary, the output becomes > > somewhat tautological: > > And rather easier to grep as the prefix is constant. memblock_ is perfectly greppable -- Sincerely yours, Mike.