From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A9DC433FE for ; Thu, 30 Sep 2021 21:12:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6726161A40 for ; Thu, 30 Sep 2021 21:12:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6726161A40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B3BE09400CD; Thu, 30 Sep 2021 17:12:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC5B094003A; Thu, 30 Sep 2021 17:12:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93C8B9400CD; Thu, 30 Sep 2021 17:12:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 7D6D494003A for ; Thu, 30 Sep 2021 17:12:55 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2FE158249980 for ; Thu, 30 Sep 2021 21:12:55 +0000 (UTC) X-FDA: 78645489510.28.68BACC1 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP id D7CDAD0005CA for ; Thu, 30 Sep 2021 21:12:54 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E7F0E61881; Thu, 30 Sep 2021 21:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633036374; bh=yQXZF8VLhtq/CkjXPsQUI56gX9vY5VW1oyXGgYiZST4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P39JgiYVF7rygVmQeuG+XvVUfbQGiMh7Xb0ilY0t7zn/ibbAi8vIT6ObkBQIHS3Hu CWFpz6uf2qM2liWSzH+BTlpn1EsJ6ilZ9tkF0A+HHWLZpPSV+VfonlgRMFen3CsrMX osa/dhAhNWV81Cn4/SC/mQJs/El+aFl/Yn4rn2JffW2YXTnqqcjPLmKmDJS/Nz/mF3 o6tFpByalXRZ/Ekb94wAYi4NGx64/KKfiro2g/TAucCPI9AlysSSw8RGJ2cyOEvL0i DzkjzW+GgF7LRme+ZehgOVbGoVIqp1+yGMYIR1WGNvBojPdAybVI53DJ8sl5JaCVqy MshIgRuwMX+xw== Date: Thu, 30 Sep 2021 14:12:52 -0700 From: Mike Rapoport To: Joe Perches Cc: Andrew Morton , linux-mm , LKML Subject: Re: [PATCH] memblock: Neaten logging Message-ID: References: <623750dd31aa3fe5e45c416be98ab37707e2c45d.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <623750dd31aa3fe5e45c416be98ab37707e2c45d.camel@perches.com> Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P39JgiYV; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D7CDAD0005CA X-Stat-Signature: 4i7q7p9h5fxmmyeh8aru83a4qskmfjgd X-HE-Tag: 1633036374-430339 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Joe, On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote: > Use more typical kernel logging styles. > > o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt I don't see it as an improvement. On the contrary, the output becomes somewhat tautological: memblock: memblock_reserve: smp_scan_config+0xa5/0xe9: [0x00000000000f5a60-0x00000000000f5a6f] memblock: memblock_reserve: smp_scan_config+0xbc/0xe9: [0x00000000000f5a70-0x00000000000f5b83] memblock: memblock_reserve: setup_arch+0x5d8/0xbcd: [0x0000000002e00000-0x0000000002e10fff] memblock: memblock_add: e820__memblock_setup+0x5e/0x76: [0x0000000000001000-0x000000000009fbff] memblock: memblock_add: e820__memblock_setup+0x5e/0x76: [0x0000000000100000-0x00000000bffdcfff] memblock: memblock_add: e820__memblock_setup+0x5e/0x76: [0x0000000100000000-0x000000013fffffff] And the output of memblock_dump_all() is perfectly fine without the prefix. > o Neaten memblock_dbg to use %s: %pS: to output __func__ and caller > o Convert existing uses of pr_ and memblock_dbg appropriately > > Logging output is now always prefixed with 'memblock: ' > Debugging output is now prefixed with 'memblock: ', function and caller > > Signed-off-by: Joe Perches > --- > mm/memblock.c | 59 ++++++++++++++++++++++++++--------------------------------- > 1 file changed, 26 insertions(+), 33 deletions(-) What is the base commit for this patch? It seems it missed a pr_warn in memblock_cap_memory_range()... > diff --git a/mm/memblock.c b/mm/memblock.c > index 184dcd2e5d99..405335c966a8 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c -- Sincerely yours, Mike.