From: Matthew Wilcox <willy@infradead.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: shakeelb@google.com, vbabka@suse.cz,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] slub: Add back check for free nonslab objects
Date: Mon, 27 Sep 2021 03:42:09 +0100 [thread overview]
Message-ID: <YVEvgfJQJ1aRerg6@casper.infradead.org> (raw)
In-Reply-To: <20210927021538.155991-1-wangkefeng.wang@huawei.com>
On Mon, Sep 27, 2021 at 10:15:38AM +0800, Kefeng Wang wrote:
> Commit ("0937502af7c9 slub: Add check for kfree() of non slab objects.")
> add the ability, which should be needed in any configs to catch the
> invalid free, they even could be potential issue, eg, memory corruption,
> use after free and double-free, so replace VM_BUG_ON_PAGE to WARN_ON, and
> add dump_page() to help use to debug the issue.
Is dump_page() really the best way to catch such a thing? I would have
thought that printing the address of 'object' would be more helpful.
> @@ -3522,7 +3522,8 @@ static inline void free_nonslab_page(struct page *page, void *object)
> {
> unsigned int order = compound_order(page);
>
> - VM_BUG_ON_PAGE(!PageCompound(page), page);
> + if (WARN_ON(!PageCompound(page)))
> + dump_page(page, "invalid free nonslab page");
next prev parent reply other threads:[~2021-09-27 2:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 2:15 Kefeng Wang
2021-09-27 2:42 ` Matthew Wilcox [this message]
2021-09-27 3:06 ` Kefeng Wang
2021-09-27 7:22 ` Vlastimil Babka
2021-09-27 7:53 ` Kefeng Wang
2021-09-28 15:43 ` Matthew Wilcox
2021-09-29 2:06 ` Kefeng Wang
2021-09-29 16:39 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVEvgfJQJ1aRerg6@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox