From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56DE3C433F5 for ; Thu, 7 Oct 2021 22:13:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E0EA4610C8 for ; Thu, 7 Oct 2021 22:13:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E0EA4610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3C0156B006C; Thu, 7 Oct 2021 18:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36FE86B0071; Thu, 7 Oct 2021 18:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25E57900002; Thu, 7 Oct 2021 18:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 142D16B006C for ; Thu, 7 Oct 2021 18:13:07 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B210882499A8 for ; Thu, 7 Oct 2021 22:13:06 +0000 (UTC) X-FDA: 78671042772.11.ECBA5CC Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf12.hostedemail.com (Postfix) with ESMTP id 73D471001AAB for ; Thu, 7 Oct 2021 22:13:06 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id c29so6534835pfp.2 for ; Thu, 07 Oct 2021 15:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PSoxPKgtUx8Cz3W1XGlx1AREdDnlsBnd21q2tDG35gc=; b=qW3jrj29Zo6JDTgt0l4U+zOb++xBTePrWQsuT5+h4ShAebzXCcnJGSdk0hcFaBYiFb bpVV/zNe8FMHo4epeIKXnM4DiND8ecR6TPQweheO9CYyDiYTsTqVtLhkYxGObZ3kkH3Z moB/ntomYDR/Pa3Jeo81t6/oUD89bv6B1zN3coYQ+XY8xFoxVOEZdOs2j26DJS6vShAj ZiykpYkvjnHTm4CP0IttCmbqQVmK0mfIAPbVMwTM4wrSMAnYW2P/0DVe493B8XCTEzGf 3TXIqMPsmSy2tBb9gKQIz9bCp2X6uPEkbYUuk9clHfNom0j72zMO3nn7R5jGoqH4ZREA Tpgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PSoxPKgtUx8Cz3W1XGlx1AREdDnlsBnd21q2tDG35gc=; b=6B42WLWcC4bzhSj+CZRAQP9ZzFaY2MrvDzTj71WG7zr8LDLsmuZbOto5V279T91ZK5 BAtp9QMjxEQ/o5uX/Fhx+8Oug3v0Ew48LHkFDQYYsviGCgJPmMYEjwFhVxJ5j2XT4TB7 3VehT1QAXGmxS71OlDrtOvKvJQ90+RTENcUX3HlzuHa1cYNJaGW89t8v4F/V1GfXMqTc bkg6ROn4nvaPH387VF+kj7Xr+4g1PN6RoqrkL9Ov4q4RRk7wI/CDK8UiXtMjrfpb4f8p piu+c/a1CjZFg2ON9iTrFlYI1nfjtDaeTEcUdzCKuWhXAJOUaXamI9bAYdsXXWJ8ZCX/ dKbQ== X-Gm-Message-State: AOAM531d5L4sd7kvBzUO/x/UP9vhMmT83PoSO5nr3rmOVc13ER0fcgGa Pq6BbYFgoGsW0lCWD67XXDy2mQ== X-Google-Smtp-Source: ABdhPJxntsFG9xEbbx22n+JcOZX6gb+uARZJFWJEf9sOIHpZmdxEEZUGGtRODs2tFLPGbJwklzHuLA== X-Received: by 2002:a65:6919:: with SMTP id s25mr1712827pgq.14.1633644785160; Thu, 07 Oct 2021 15:13:05 -0700 (PDT) Received: from google.com (64.157.240.35.bc.googleusercontent.com. [35.240.157.64]) by smtp.gmail.com with ESMTPSA id y22sm9360044pjj.33.2021.10.07.15.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Oct 2021 15:13:04 -0700 (PDT) Date: Thu, 7 Oct 2021 22:12:57 +0000 From: Matthew Bobrowski To: Christian Brauner Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Suren Baghdasaryan , Alexander Duyck , Jan Kara Subject: Re: [PATCH 0/2] Introduce simple pidfd to task helper Message-ID: References: <20211004125050.1153693-1-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211004125050.1153693-1-christian.brauner@ubuntu.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 73D471001AAB X-Stat-Signature: jtbzcnn6n1x6hpskfkz67h8qsrcyjudk Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qW3jrj29; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf12.hostedemail.com: domain of repnop@google.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=repnop@google.com X-HE-Tag: 1633644786-141224 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 04, 2021 at 02:50:48PM +0200, Christian Brauner wrote: > Hey everyone, > > This adds a simple helper to get rid of some code duplication introduced > with the addition of two new pidfd-based syscalls in mm. We should've > probably added the helper right away and I think I mentioned this during > in the review on one of the revisions but we probably just lost track of > it. If this looks ok to you, I'll queue this up for next. I went through the series. Seems like a very sensible thing to do, so thanks for adding the helper and updating the call sites accordingly. Reviewed-by: Matthew Bobrowski > Christian Brauner (2): > pid: add pidfd_get_task() helper > mm: use pidfd_get_task() > > include/linux/pid.h | 1 + > kernel/pid.c | 34 ++++++++++++++++++++++++++++++++++ > mm/madvise.c | 15 +++------------ > mm/oom_kill.c | 15 +++------------ > 4 files changed, 41 insertions(+), 24 deletions(-) > > > base-commit: 9e1ff307c779ce1f0f810c7ecce3d95bbae40896 > -- > 2.30.2 > /M