From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2715CC433F5 for ; Thu, 7 Oct 2021 16:18:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B0B7461130 for ; Thu, 7 Oct 2021 16:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B0B7461130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 46A0C900002; Thu, 7 Oct 2021 12:18:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 419BF6B0071; Thu, 7 Oct 2021 12:18:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E0E3900002; Thu, 7 Oct 2021 12:18:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 1BE056B006C for ; Thu, 7 Oct 2021 12:18:44 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D15622D252 for ; Thu, 7 Oct 2021 16:18:43 +0000 (UTC) X-FDA: 78670149726.38.F6698E0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 7CB673000B7C for ; Thu, 7 Oct 2021 16:18:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633623523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g2BhWp9ye5wWG2ktl9BRS9ejL5FqZFg78PPEny8VjKw=; b=hLmCdAqEvZWZzAQngalY8cNIQJJYQ6eIS37ZFPh70EluAbj2vj4EcAG7g5ppfzLULFtt5k ZGtGwIeM9hdFLeJsimRz2lThYDTikIbppX+/pqMJG5vlwYX3Hmqz9krB01kmED4pdyC/tg j+j4mSFca7tcKrG7treJSWBktNGN6CY= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-Wo5m5Ep5M_Wmd7GbvrwJRA-1; Thu, 07 Oct 2021 12:18:41 -0400 X-MC-Unique: Wo5m5Ep5M_Wmd7GbvrwJRA-1 Received: by mail-qv1-f69.google.com with SMTP id p9-20020a05621421e900b003830bb235fbso6118049qvj.14 for ; Thu, 07 Oct 2021 09:18:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g2BhWp9ye5wWG2ktl9BRS9ejL5FqZFg78PPEny8VjKw=; b=qqDCHmHm7c2E/0jlfze7kgHUFIyrYS3uYX7846Ie0gZ2Ry+B3xb0UE2OJuAUAnBJnD N80SGrE1rkv+FNNFuHcPihX9WDwDHRmDWpYbH4aJY9UGVCE5wNFC/Ph7WDvfdCPB5QB4 TJLIe0PoZy9/DTV/KsErkgvl3tFT0NStFNeFuNk2hVYjDxQ6MnBB729uD73cqXOWFpU9 711STeHFB4jtbAiQEz4xAr6yhxGae5ho7wl/PIMk7lbaopyzISP5MR4d+8w8okiUp7P7 j0JykDU6+6A/JFQPwMV/L5lJoQgNNWCwe/ZNDU7I4mc2O+fUVpjZ6uIB6t3v3+4ivaxZ PNUg== X-Gm-Message-State: AOAM530lxzuMPU9cRSv2hn8e2u7sv6XlpQyP3dmR5RawZc89LOi7y08x zj/gcg4pIlzX/u5K79nv+vbGxSaataiZ3KzD9lT4xZKhGTap5IukSR2A1rO+5EnlAAyYOzkC8TC /Kiys/rkvbf0= X-Received: by 2002:ae9:d604:: with SMTP id r4mr3995161qkk.401.1633623521167; Thu, 07 Oct 2021 09:18:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzISNgoyX8ThhELtimobeSv0obTz8WwchRnJ53hCvPdL8MPEoqR1UNazjrmPhIn7tsohgi8HA== X-Received: by 2002:ae9:d604:: with SMTP id r4mr3995128qkk.401.1633623520953; Thu, 07 Oct 2021 09:18:40 -0700 (PDT) Received: from t490s ([2607:fea8:56a2:9100::bed8]) by smtp.gmail.com with ESMTPSA id h66sm13982024qkc.5.2021.10.07.09.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Oct 2021 09:18:40 -0700 (PDT) Date: Thu, 7 Oct 2021 12:18:39 -0400 From: Peter Xu To: Yang Shi Cc: HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+jIOebtOS5nyk=?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Subject: Re: [v3 PATCH 3/5] mm: hwpoison: refactor refcount check handling Message-ID: References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-4-shy828301@gmail.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7CB673000B7C X-Stat-Signature: 9n6tzcrz5p6p4ekpb6u3ep6kbi1tj9ao Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hLmCdAqE; spf=none (imf03.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1633623523-406710 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 06, 2021 at 07:47:20PM -0700, Yang Shi wrote: > Yeah, it is intentional. Before this change all me_* handlers did > check refcount even though it was not necessary, for example, > me_kernel() and me_unknown(). Would you mind add some explanation into the commit message on what kind of pages dropped the refcount check, and why they can be dropped, when you respin? Thanks a lot. -- Peter Xu