From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB22EC4332F for ; Thu, 7 Oct 2021 16:14:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D35A6105A for ; Thu, 7 Oct 2021 16:14:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4D35A6105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D6F526B006C; Thu, 7 Oct 2021 12:14:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1F7D6B0071; Thu, 7 Oct 2021 12:14:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE6C3900002; Thu, 7 Oct 2021 12:14:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id B0B486B006C for ; Thu, 7 Oct 2021 12:14:21 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6B1FC180CD607 for ; Thu, 7 Oct 2021 16:14:21 +0000 (UTC) X-FDA: 78670138722.13.AB8E374 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 10160B001BC7 for ; Thu, 7 Oct 2021 16:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633623260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pRgvQy7zCNT4x1FLGa0VFDNRf/XMV/VudzeiNbniOTk=; b=EZJ9QbUWbrdeaIJFKC78YvRxXSGRLo+rOXPmzcoiyfpvbHcRnJ3PBhjFw4IOiPFqFAT+9A SYzIi5mm2GUysqT9mwA/SQ2+KtZAZuUch4zpIMurplcKPuTyvjm3lnt5rP7Bk+TbkCT4+I HjTBnK4WTSm/xyYtKU9zzJc8pWW24U0= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-306-N2nfooUxNH-Yv4TxW3GgCQ-1; Thu, 07 Oct 2021 12:14:16 -0400 X-MC-Unique: N2nfooUxNH-Yv4TxW3GgCQ-1 Received: by mail-qv1-f70.google.com with SMTP id a16-20020a0ccdd0000000b003830ff134ccso6107280qvn.6 for ; Thu, 07 Oct 2021 09:14:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pRgvQy7zCNT4x1FLGa0VFDNRf/XMV/VudzeiNbniOTk=; b=I8djpCMptn7xCT3mcGd0QbcsHz/i2HY+W872yFLXUdCrJk59+R7enZIoMuUjq7eZAk xxWto972GkVS7WI5POvhz5H9yOdISp07lEmIMwjW+CiCv+DkdWyRrrN9/PX7whtquW5d FGONMavFMb9VFmpH2PioUdr+im2wkX+9Plk/iOmVVhqJeYKcsn9y9Mu/LPAfCPQWBSC9 HZuN908DYF0erpp5315iXKOHavouCkg0szErGo/ayejAt10tQJ/hqflg5bwvFLSEGC5c UP1czz78b1psOwA4XGDcffRlShKPSw6XP2ZWUQC2MDpy8KxOPAyYKogp7bd/rCjejqO6 amAA== X-Gm-Message-State: AOAM530GhFLqWJNVaP58AhBktDvj71K5h+iO91MWDWn1JCV+vQd8kYk4 emiQ2TpCW0fgeoGppI7F/R9Ag1hFGH6gstqOoqW+3IoaMAyX1o4rRZqFfvQ9wQbZiMYLM4t7RbA +q7aCkCmGp8A= X-Received: by 2002:a05:620a:1677:: with SMTP id d23mr4266631qko.327.1633623255961; Thu, 07 Oct 2021 09:14:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRhDipkWMKBlUwNt0I0VU8YiJcFyvPa0zwdSqGd/2TPm7Sb3wfxySQ+irOIRCQ5YvPvWvFvQ== X-Received: by 2002:a05:620a:1677:: with SMTP id d23mr4266603qko.327.1633623255749; Thu, 07 Oct 2021 09:14:15 -0700 (PDT) Received: from t490s ([2607:fea8:56a2:9100::bed8]) by smtp.gmail.com with ESMTPSA id i18sm16970001qtx.60.2021.10.07.09.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Oct 2021 09:14:15 -0700 (PDT) Date: Thu, 7 Oct 2021 12:14:13 -0400 From: Peter Xu To: Yang Shi Cc: "Kirill A. Shutemov" , HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+jIOebtOS5nyk=?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Subject: Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault Message-ID: References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-3-shy828301@gmail.com> <20211004140637.qejvenbkmrulqdno@box.shutemov.name> <20211004194130.6hdzanjl2e2np4we@box.shutemov.name> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EZJ9QbUW; spf=none (imf24.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 10160B001BC7 X-Stat-Signature: jeoftsnq538hshemhk73gxhawamxeq5x X-HE-Tag: 1633623260-946583 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 06, 2021 at 04:41:35PM -0700, Yang Shi wrote: > > Or maybe we just don't touch it until there's need for a functional change? I > > feel it a pity to lose the git blame info for reindent-only patches, but no > > strong opinion, because I know many people don't think the same and I'm fine > > with either ways. > > TBH I really don't think keeping old "git blame" info should be an > excuse to avoid any coding style cleanup. Sure. > > > > > Another side note: perhaps a comment above pageflags enum on PG_has_hwpoisoned > > would be nice? I saw that we've got a bunch of those already. > > I was thinking about that, but it seems PG_double_map doesn't have > comment there either so I didn't add. IMHO that means we may just need even more documentations? :) I won't ask for documenting doublemap bit in this series, but I just don't think it's a good excuse to not provide documentations if we still can. Especially to me PageHasHwpoisoned looks really so like PageHwpoisoned, so it'll be still very nice to have some good document along with the patch it's introduced. Thanks, -- Peter Xu