From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26445C433F5 for ; Thu, 7 Oct 2021 14:49:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BE22361245 for ; Thu, 7 Oct 2021 14:49:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BE22361245 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 36F996B0071; Thu, 7 Oct 2021 10:49:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31F336B0072; Thu, 7 Oct 2021 10:49:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20DB56B0073; Thu, 7 Oct 2021 10:49:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 0D79B6B0071 for ; Thu, 7 Oct 2021 10:49:06 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BEE3C8249980 for ; Thu, 7 Oct 2021 14:49:05 +0000 (UTC) X-FDA: 78669923850.11.859FD9B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 15D836003AC9 for ; Thu, 7 Oct 2021 14:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZaIfgTqAECN8YQ33y/H4ix8XO1DsmTwgYAAz8mNepJ4=; b=UWLTO4OYqlkhtknN3F38R9qZPa 9jUTnzWFNyLxIivdRQFEtrB0Kqt156B/4BYk1JecPqj1DIwoWz67JNuNnsBlIO3Vx6dwhXrUzfSNm c8AjDfYa3h2JW18/puPFnqLd3xS6hYvAjarYajk2xaiGvRI9I46YyRYRL1i4yU3m1bn8O4y4845sD juKN3MXr+xCk/v5kQWaiYkuziW2yHba/Bo4alFGnnIcUGIqSE5FtU+afLHLj7VB3cp82aMkgHWeBx DIixh912OAw5KPUnU4p2IfapNz2GDw5vynxGtHVD25xCobRoPRMx42bFtDnG3TtAVpLaFN413PVA7 qAe9z50w==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYUhA-001wgg-0z; Thu, 07 Oct 2021 14:48:38 +0000 Date: Thu, 7 Oct 2021 15:48:28 +0100 From: Matthew Wilcox To: Vlastimil Babka Cc: linux-mm@kvack.org, David Hildenbrand , Kent Overstreet , Johannes Weiner , linux-fsdevel@vger.kernel.org Subject: Re: [RFC] pgflags_t Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 15D836003AC9 X-Stat-Signature: 17wr3za673fdtxwdjpzjq7qmwi3xzdwm Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=UWLTO4OY; dmarc=none; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1633618144-217685 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 07, 2021 at 04:37:08PM +0200, Vlastimil Babka wrote: > > - pr_warn("%sflags: %#lx(%pGp)%s\n", type, head->flags, &head->flags, > > + pr_warn("%sflags: %#lx(%pGp)%s\n", type, head->flags.f, &head->flags.f, > > The %pGp case (here and elsewhere) could perhaps take the new type, no? > Would need to change format_page_flags() and flags_string() in lib/vsprintf.c Oh, good point. I don't think format_page_flags() would _need_ to change, but we might _want_ to change it. Particularly if we go with Al Viro's suggestion of using __bitwise to create a new type that's checked with sparse.