From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B77EAC43219 for ; Thu, 7 Oct 2021 08:09:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 54197610EA for ; Thu, 7 Oct 2021 08:09:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 54197610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A65026B006C; Thu, 7 Oct 2021 04:09:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A15516B0071; Thu, 7 Oct 2021 04:09:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DC97900002; Thu, 7 Oct 2021 04:09:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 7FAFD6B006C for ; Thu, 7 Oct 2021 04:09:08 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 39B5F1813F3D9 for ; Thu, 7 Oct 2021 08:09:08 +0000 (UTC) X-FDA: 78668915976.02.12781E2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id CAE733001424 for ; Thu, 7 Oct 2021 08:09:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9CFFE225F4; Thu, 7 Oct 2021 08:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1633594146; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vZ78DbAR+r/e/r6GYTwg4MxP7fk6xf1yQWORN1dcpaw=; b=p/Sjmspufjnzjjein9NvN3QmLYZhdyAyB0P0BiEw/nO0oDKX6ZKsoQDpDfFMhkcKuArLRN fPH4WEuNCqaQ9xxgOiNhGRVVrXuN1qC+dLhq3H65JcZz//9vtSrXeX6sw73n9G6uYsPW0s 2H+6gC3mhVlYrBwHlU2eArtih6Dm2FY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1633594146; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vZ78DbAR+r/e/r6GYTwg4MxP7fk6xf1yQWORN1dcpaw=; b=d7GACDCTta4X67QvurOXYEnWzqbvKqOo3kXRGX7FXuY1MWnD0h4KBmo3KUWYLvUGJahujc q2Aj7atscFaMIcDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2CC2813A9B; Thu, 7 Oct 2021 08:09:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id i1ruByGrXmEPEAAAMHmgww (envelope-from ); Thu, 07 Oct 2021 08:09:05 +0000 Date: Thu, 7 Oct 2021 10:09:03 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Alex Shi , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Greg Kroah-Hartman , "Rafael J. Wysocki" , "Michael S. Tsirkin" , Jason Wang , Shuah Khan , Michal Hocko , Mike Rapoport , x86@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v1 1/6] mm/memory_hotplug: remove CONFIG_X86_64_ACPI_NUMA dependency from CONFIG_MEMORY_HOTPLUG Message-ID: References: <20210929143600.49379-1-david@redhat.com> <20210929143600.49379-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929143600.49379-2-david@redhat.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CAE733001424 X-Stat-Signature: r3rnkiookm88gswit39dqpuz81z1a85u Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="p/Sjmspu"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=d7GACDCT; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-HE-Tag: 1633594147-446716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 29, 2021 at 04:35:55PM +0200, David Hildenbrand wrote: > SPARSEMEM is the only possible memory model for x86-64, FLATMEM is not > possible: > config ARCH_FLATMEM_ENABLE > def_bool y > depends on X86_32 && !NUMA > > And X86_64_ACPI_NUMA (obviously) only supports x86-64: > config X86_64_ACPI_NUMA > def_bool y > depends on X86_64 && NUMA && ACPI && PCI > > Let's just remove the CONFIG_X86_64_ACPI_NUMA dependency, as it does no > longer make sense. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index d16ba9249bc5..b7fb3f0b485e 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -123,7 +123,7 @@ config ARCH_ENABLE_MEMORY_HOTPLUG > config MEMORY_HOTPLUG > bool "Allow for memory hot-add" > select MEMORY_ISOLATION > - depends on SPARSEMEM || X86_64_ACPI_NUMA > + depends on SPARSEMEM > depends on ARCH_ENABLE_MEMORY_HOTPLUG > depends on 64BIT || BROKEN > select NUMA_KEEP_MEMINFO if NUMA > -- > 2.31.1 > > -- Oscar Salvador SUSE Labs