From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D3DC433EF for ; Wed, 6 Oct 2021 20:18:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 845CB61090 for ; Wed, 6 Oct 2021 20:18:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 845CB61090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EF8B26B006C; Wed, 6 Oct 2021 16:18:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA7CA6B0071; Wed, 6 Oct 2021 16:18:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D968F900002; Wed, 6 Oct 2021 16:18:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id C86E06B006C for ; Wed, 6 Oct 2021 16:18:52 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7BC141801C5F4 for ; Wed, 6 Oct 2021 20:18:52 +0000 (UTC) X-FDA: 78667126104.28.9B7ABF9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 266EA1000BBE for ; Wed, 6 Oct 2021 20:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633551531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ndoPsgxw3pXa2WkzFUSKjNPOdhdtHbMEsZXh2h30JEc=; b=NPckKvoR1CHgo6deH3aBUg6HgcGywgu0mjDhueYLuXpwxY9PUKRPPzS5+FvI3+L8SccRwD pl2o6B692iKPuQkQokJdeH0HG8OODHjakNDGLaegNaY9iPlpn0L/xXTZIw4CBBrJ5X5TWL ZRy52nGZQEhxKJiUGGBTn+5lkRyGVZs= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-74-NjdxGQUVPz6dCCkfVnZr-A-1; Wed, 06 Oct 2021 16:18:50 -0400 X-MC-Unique: NjdxGQUVPz6dCCkfVnZr-A-1 Received: by mail-qv1-f70.google.com with SMTP id o90-20020a0c85e3000000b0038310a20003so3669147qva.1 for ; Wed, 06 Oct 2021 13:18:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ndoPsgxw3pXa2WkzFUSKjNPOdhdtHbMEsZXh2h30JEc=; b=0dYza15McVu2MyJY4GE6O+Cx7QvTNkjIE2z+UKR2H/lwzXwBrcrqVVN4M8WPcGoxQ3 e1du0cb9JlpJ5bu1+MoudiKvrsIrtptwJqF9HitV6KqwkNoJYgAHIszAdqYvhLbrtcJ7 6JH8gxBmfw+MWWJBaCI4oXLnpHi2yA7UYyPDIlzzdnxFMO+6rCvnUHv+Ih9rkW7G/4Jr 2SztRUNrwvxMuS8KMCiFUbHUv61biq0N5k6YvfcFFDguwErC18+Q5U5nny53FgBGT3hJ /UNq5m6jsdHQmmMBsqufE0T4zJhcq2xyE2qQhYXcUzclBcbcix99bQETI02hNQNu6Q+6 2Qlw== X-Gm-Message-State: AOAM532tyrQ6SlvoHMP0CW6bcB2FNGqOBFx2dy9VgRB2aR3xiNvmaerE GwPVbEWt9i8fRIGrfzuQQk2run7mJrnQl3t6mnCb7bzUB8BWs1/7kYVJiN8yGadhOsrFAKRyJz5 1/ZqDnX4Var8= X-Received: by 2002:ac8:40da:: with SMTP id f26mr279400qtm.114.1633551530172; Wed, 06 Oct 2021 13:18:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKZ1/nqV2JLDLruE0ZKjTUxqTpHKJD6s6mBT9Z4jMzAijU04nZ79wKZ6V6d9P6rkNvidggIQ== X-Received: by 2002:ac8:40da:: with SMTP id f26mr279377qtm.114.1633551529986; Wed, 06 Oct 2021 13:18:49 -0700 (PDT) Received: from t490s ([2607:fea8:56a2:9100::bed8]) by smtp.gmail.com with ESMTPSA id q8sm13891462qtl.80.2021.10.06.13.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 13:18:49 -0700 (PDT) Date: Wed, 6 Oct 2021 16:18:48 -0400 From: Peter Xu To: Yang Shi Cc: naoya.horiguchi@nec.com, hughd@google.com, kirill.shutemov@linux.intel.com, willy@infradead.org, osalvador@suse.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault Message-ID: References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-3-shy828301@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210930215311.240774-3-shy828301@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 266EA1000BBE X-Stat-Signature: ei5rgyhsgdjqpjftaofy7t1r98nkzg9e Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NPckKvoR; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf07.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com X-HE-Tag: 1633551532-643005 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 30, 2021 at 02:53:08PM -0700, Yang Shi wrote: > +#ifdef CONFIG_MEMORY_FAILURE > + /* Compound pages. Stored in first tail page's flags */ > + PG_has_hwpoisoned = PG_mappedtodisk, > +#endif Sorry one more comment I missed: would PG_hwpoisoned_subpage better? It's just that "has_hwpoison" can be directly read as "this page has been hwpoisoned", which sounds too close to PG_hwpoisoned. No strong opinion either. Thanks, -- Peter Xu