From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 575B6C433EF for ; Thu, 23 Sep 2021 15:22:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F0E8A60EE5 for ; Thu, 23 Sep 2021 15:22:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F0E8A60EE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7C7B16B006C; Thu, 23 Sep 2021 11:22:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 777B3900003; Thu, 23 Sep 2021 11:22:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61879900002; Thu, 23 Sep 2021 11:22:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 533276B006C for ; Thu, 23 Sep 2021 11:22:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0E91F3208F for ; Thu, 23 Sep 2021 15:22:43 +0000 (UTC) X-FDA: 78619205406.11.A69D15A Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf05.hostedemail.com (Postfix) with ESMTP id C0975505F6DF for ; Thu, 23 Sep 2021 15:22:42 +0000 (UTC) Received: by mail-qk1-f178.google.com with SMTP id p4so23470107qki.3 for ; Thu, 23 Sep 2021 08:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HVxL0gvQeVwNSk7LMfLCfUfPmAJPbw6emcr/92Y6HPk=; b=p+5JZA/d0QPeEFee2vyGl0teLRbu+HhGmmfCC0GugTpHLUpXa2mLytkqGART6iVOgX nSocO8bRUPBGxcQYeC9A2+FRcSZVyaf441Haqy9KwVnJ6j48u4Pi5zcTQbOgp2XXLWoV ALe6HnXjJbk0ytmMafoFSeFw6yaLzTsZLClFvK2vKW544icq1yjPSkTHEcqgqAqHSwg9 QUUFS9Dj2NHiP4vAVCS2IIKa0Hxhnz+an7+gD49oSnxRJ67N8wltVx7jF4CjXnZi5C3k /V7Ut1KmhKzIq91iI/vcVTO9lM6JbCPfMXuBvDre6n4T8ROlZdPn6+PuChs38Ge2dg2b rbuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HVxL0gvQeVwNSk7LMfLCfUfPmAJPbw6emcr/92Y6HPk=; b=dJQ8UGCBAiLgrIcMS6+HkJ2EaXkn3ukz4q8Jja7ysp7YSAnBvyE8OaP4hIm5wmLpDQ Z1F9FFE2a8Ib34KvE7rRveyIv7Ez/kfUJJJ1peJJ5UsLhnExfaLEF/HfFpNgO16t1BNC 3pA9BW8ILWwBO3IZ2VcPLsiEFdCcsRWHPfMC/jM6E8jfqm08D3N9ae5/l3htI0HLSySG cT3VOp4Bz93uO6rI/N3uGUo9G+qpCsrssFLUNQoKQ1vz10gq5/QcE3mFANjqls7EgJUv xfX6hUOTojVGWnsjVqcPUHwDVyB9IWKpD1K47j3yRhLwOVLp8+jslwGjNw/cB1szXWG4 CcIQ== X-Gm-Message-State: AOAM530s37tOZH82zA6Op9RqzCN3oGJ45GzvhReSsqTnuMED3lTmFTLh q8IFbO2LIE6rEAtKCgLKig== X-Google-Smtp-Source: ABdhPJxksgW3toWKjh5yTplDAjHXG0UVdVM765dWPTWwIfBpqQcVOllpbDWkWcyt9BuLJjXr4x9dyw== X-Received: by 2002:a05:620a:530:: with SMTP id h16mr5269737qkh.230.1632410562138; Thu, 23 Sep 2021 08:22:42 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id z186sm4409646qke.59.2021.09.23.08.22.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 08:22:41 -0700 (PDT) Date: Thu, 23 Sep 2021 11:22:35 -0400 From: Kent Overstreet To: David Hildenbrand Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner , Matthew Wilcox , Linus Torvalds , Andrew Morton , "Darrick J. Wong" , Christoph Hellwig , David Howells Subject: Re: Struct page proposal Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C0975505F6DF X-Stat-Signature: tmmkgm4w5mjg6iu77y3cf8h4nmj7m3c8 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="p+5JZA/d"; spf=pass (imf05.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.222.178 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1632410562-373848 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 23, 2021 at 11:03:44AM +0200, David Hildenbrand wrote: > Don't get me wrong, but before there are answers to some of the very basic > questions raised above (especially everything that lives in page->flags, > which are not only page flags, refcount, ...) this isn't very tempting to > spend more time on, from a reviewer perspective. Did you miss the part of the folios discussion where we were talking about how acrimonious it had gotten and why, and talking about (Chris Mason in particular) writing design docs up front and how they'd been pretty successful in other places? We're trying something new here, and trying to give people an opportunity to discussion what we're trying to do _before_ dumping thousands and thousands of lines of refactoring patches on the list.