From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6252AC433F5 for ; Tue, 21 Sep 2021 12:02:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F3EA060E76 for ; Tue, 21 Sep 2021 12:02:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F3EA060E76 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6FF266B0075; Tue, 21 Sep 2021 08:02:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 687F66B0078; Tue, 21 Sep 2021 08:02:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 550EB900003; Tue, 21 Sep 2021 08:02:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id 316326B0075 for ; Tue, 21 Sep 2021 08:02:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 53CA42771B for ; Tue, 21 Sep 2021 12:02:44 +0000 (UTC) X-FDA: 78611443848.02.6ADFB92 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf27.hostedemail.com (Postfix) with ESMTP id 82F5670000A2 for ; Tue, 21 Sep 2021 12:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IfRki3AzeqFPSY1IcCd0GKhZLpBNuXjfdDsJMIiSeII=; b=elbDprCo4hEZOCgsHDzy69dPsw 1cQd7+07UT4V7idJYCNvfafVTE7Djq4o3rg3QbkckPjcYLu1S5swLoPU0XxmhjCs+w6vH8nYQrZ2O hqwL/HbnDIFcmHlhoOdLTMyPq2R7wm+L+SxGHAvu1GO7Vs/3JILIEuvryKt/SG/b/Cn9fMm7t7+TS ZCGM9Pvpq//yAz3rvtDe9iM3zUy1avX6FKg7uLUNyjWW0X7eUg3eN+jqgUCRZRvYxXZpBOSHLd9tE fIihHi5pL1ipUVYmjm1/7bnk/vTu0OMMOSZua8BwcVqNaQ15ogK1BZpGExU0aKi4LcMPPVy4i65EO Ze49qMeQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSeTw-004l5w-GA; Tue, 21 Sep 2021 12:02:40 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id BF1393001CD; Tue, 21 Sep 2021 14:02:39 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A561A20303903; Tue, 21 Sep 2021 14:02:39 +0200 (CEST) Date: Tue, 21 Sep 2021 14:02:39 +0200 From: Peter Zijlstra To: sxwjean@me.com Cc: x86@kernel.org, linux-mm@kvack.org, Xiongwei Song Subject: Re: [PATCH 2/2] x86/mm: Randomize va with generic arch_pick_mmap_layout() Message-ID: References: <20210921110252.2593542-1-sxwjean@me.com> <20210921110252.2593542-3-sxwjean@me.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210921110252.2593542-3-sxwjean@me.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 82F5670000A2 X-Stat-Signature: g1aefbws4sz5o8hrddrchzuzqzy4uukk Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=elbDprCo; spf=none (imf27.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none X-HE-Tag: 1632225763-872230 X-Bogosity: Ham, tests=bogofilter, spamicity=0.049854, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 21, 2021 at 07:02:52PM +0800, sxwjean@me.com wrote: > +static inline int is_compat_task(void) > +{ > + return IS_ENABLED(CONFIG_COMPAT) && test_thread_flag(TIF_32BIT); > +} This is fundamentally broken.