From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE52C433EF for ; Mon, 20 Sep 2021 23:50:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 34D896124C for ; Mon, 20 Sep 2021 23:50:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 34D896124C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6D80D94000D; Mon, 20 Sep 2021 19:50:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 660A694000B; Mon, 20 Sep 2021 19:50:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B24E94000D; Mon, 20 Sep 2021 19:50:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 35B3D94000B for ; Mon, 20 Sep 2021 19:50:21 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EED622AF1F for ; Mon, 20 Sep 2021 23:50:20 +0000 (UTC) X-FDA: 78609598200.40.FB088A1 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf03.hostedemail.com (Postfix) with ESMTP id BA39D30000AE for ; Mon, 20 Sep 2021 23:50:20 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id k23so13169407pji.0 for ; Mon, 20 Sep 2021 16:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vrcaCp8wAG9WhMElbt3SFMZG1ccQwS5//7td2G4tQVw=; b=LbiW+vJtWL6WTaQ9//JZW46yS0oAh/MegbVt3qRem/mZh8AZkW9/CtaaV68C2JpLDq HCdEdkmUj0NM+oSrHNiBCk1krYVqBi3PQQ8J0h7ZpCH4Ac26oiLjkr6fDYzW/yypRVxI dIAH6YU2L4BTKvOgMUjY4umP3hCeLgZkWgkaofw2QzaVmalf7TfjuNS/tC6L9AH9SRac QeG/LDCjrFoimKWuFio9+wRhYfdJo4F255JIdMSb3NSElXNXzRGesDkCUNn+PJZdsBwR K/p0IX7K4Ekh23lwVSeZXVedOFnpeqYCwmPPtx545Xo9cis/N5oZ48V1MQiP2CWkTK6e 36Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=vrcaCp8wAG9WhMElbt3SFMZG1ccQwS5//7td2G4tQVw=; b=EcP+7yHjwVq6KgMmFyLM9vCOOb+QYL4z7yZXUhDp4be+5wYwqbcNS0Lu9bNcHZvtKY Kh6gF0ZHHO2zTLzlQiBcckDBtXu4RGpDG+9q4Pk8MUQIovS1gkKyTDLI3l5/fFMokp96 q0YXxYp2m43Hcl+YJurGyz5P1zUr70WDuXXZTgdDsPraCBlVagrowBLNMS757PBoQ6Cn 8LhO6SHfEE1/RkwZWe4vSAx33cMe6843SNqNVUM3J+qIY9ZvUyvS/NezofKGGgUfFrXk 8PY1+CkAt4KS7FJlRfgq+QWiY7WYyr5u7LsMxzOiCoeuw4jFMdukeCr3aennUQbvbRMn Fkuw== X-Gm-Message-State: AOAM530APOIf3fR7CCmIeEh3EYwMKdx06POIPOMOH1YAWm7fsVBlcvDR p7rJ2OjIKZDzRfKQqF3Jpak= X-Google-Smtp-Source: ABdhPJyCkWnH/ODUdB0PfCikz0qGRII4E6ykCQSbknL+UxCNgxM+O1u+BheueEC6OBltMBZncJh5CA== X-Received: by 2002:a17:90a:f2cd:: with SMTP id gt13mr1779693pjb.153.1632181819626; Mon, 20 Sep 2021 16:50:19 -0700 (PDT) Received: from google.com ([2620:15c:211:201:9a49:e1f0:6fe9:6fd9]) by smtp.gmail.com with ESMTPSA id e13sm15147485pfi.210.2021.09.20.16.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 16:50:19 -0700 (PDT) Date: Mon, 20 Sep 2021 16:50:16 -0700 From: Minchan Kim To: Linus Torvalds , zhengjun.xing@intel.com Cc: Andrew Morton , Laura Abbott , Oliver Sang , David Hildenbrand , John Dias , Matthew Wilcox , Michal Hocko , Suren Baghdasaryan , Vlastimil Babka , LKML , linux-mm , lkp@lists.01.org, kernel test robot , "Huang, Ying" , Feng Tang , zhengjun.xing@intel.com, Chris Goldsworthy Subject: Re: [PATCH v3] mm: fs: invalidate bh_lrus for only cold path Message-ID: References: <20210907212347.1977686-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LbiW+vJt; spf=pass (imf03.hostedemail.com: domain of minchan.kim@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=minchan.kim@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) X-Stat-Signature: 43gxcrw3uxegfbuodijpoz7p6miqo15m X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BA39D30000AE X-HE-Tag: 1632181820-325219 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 20, 2021 at 04:29:52PM -0700, Linus Torvalds wrote: > On Tue, Sep 7, 2021 at 2:24 PM Minchan Kim wrote: > > > > kernel test robot reported the regression of fio.write_iops[1] > > with [2]. > > > > Since lru_add_drain is called frequently, invalidate bh_lrus > > there could increase bh_lrus cache miss ratio, which needs > > more IO in the end. > > > > This patch moves the bh_lrus invalidation from the hot path( > > e.g., zap_page_range, pagevec_release) to cold path(i.e., > > lru_add_drain_all, lru_cache_disable). > > Was this confirmed to fix the regression? > > I only see the "tested with 5.14" that the regression was still there > > https://lore.kernel.org/lkml/034fc860-d0d0-0c61-09d2-3c41c4f020c6@intel.com/ > > I don't see a confirmation that this patch fixed it. > > It looks likely, but if you have the confirmation somewhere, it would > help to link that too. > > Or did I miss it? I have no idea why I couldn't find the reply from lore.kernel.org/lkml/ The message id was 89e2b66b-c706-c020-bff5-b815dcd5c461@intel.com in the thread(https://lore.kernel.org/lkml/20210520083144.GD14190@xsang-OptiPlex-9020/) Xing, Zhengjun zhengjun.xing@intel.com confirmed Quote - ``` Hi Minchan, ... I test the patch, the regression reduced to -2.9%. ``` Since then, I modified the patch a little more and couldn't find the message from the public URL. Thus, do we need to confirm it again against latest kernel? Xing, could you confirm whether this patch fixes the regression?