From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAF72C433F5 for ; Sun, 19 Sep 2021 19:18:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3926360F92 for ; Sun, 19 Sep 2021 19:18:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3926360F92 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 38861900003; Sun, 19 Sep 2021 15:18:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3391F900002; Sun, 19 Sep 2021 15:18:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24D99900003; Sun, 19 Sep 2021 15:18:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id 11CE6900002 for ; Sun, 19 Sep 2021 15:18:57 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B11078249980 for ; Sun, 19 Sep 2021 19:18:56 +0000 (UTC) X-FDA: 78605285472.32.84DDF8B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 5D7987001A23 for ; Sun, 19 Sep 2021 19:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JrB8crO5qmaGGk/74p/+OVhuoZ1TfR35Lx0zXoUidCI=; b=rCz14sYtUeua4iC+9TqwrhIiUw I56zfeXHqGOVnH/VuCZnHcNFI8FtqNp0tjAdVosBlKR/G2dPRBhOgoNRxRSSlWV2+umiSQQq46nBh 8GADJj/calkA6xctVt4qeHyp5oXBsBL8/qi/BJEvBDovDDNlxV0BQHXnIst8G1CMpq4pE+8T0sdxx RtaXz6r3jOqNi9fBqBN+87fRWOsNN2XibRgirfQAdfWyefht+VsWsgl3G4rY9PiGCxdUV2gJpVo3C kSznnWhx8cl+vtDYDr/W44mH9wz0vBDzwgvCubbuIkCwHp7XA6DemFMVZ6D+6KEWf4AAmj2m+Gvx0 +NVIIoVA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS2Js-0025mj-By; Sun, 19 Sep 2021 19:17:56 +0000 Date: Sun, 19 Sep 2021 20:17:44 +0100 From: Matthew Wilcox To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jens Axboe Subject: Re: [RFC PATCH] Introducing lockless cache built on top of slab allocator Message-ID: References: <20210919164239.49905-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210919164239.49905-1-42.hyeyoo@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5D7987001A23 X-Stat-Signature: zrjxmfzp6bhuz5qh6ekhhpj76jibex6f Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rCz14sYt; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1632079136-965947 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 19, 2021 at 04:42:39PM +0000, Hyeonggon Yoo wrote: > It is just simple proof of concept, and not ready for submission yet. > There can be wrong code (like wrong gfp flags, or wrong error handling, > etc) it is just simple proof of concept. I want comment from you. Have you read: https://www.usenix.org/legacy/event/usenix01/full_papers/bonwick/bonwick_html/ The relevant part of that paper is section 3, magazines. We should have low and high water marks for number of objects, and we should allocate from / free to the slab allocator in batches. Slab has bulk alloc/free APIs already. I'd rather see this be part of the slab allocator than a separate API.