From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2923BC433F5 for ; Sun, 19 Sep 2021 14:22:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9E5BB60F6E for ; Sun, 19 Sep 2021 14:22:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9E5BB60F6E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C02076B006C; Sun, 19 Sep 2021 10:22:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB1F06B0072; Sun, 19 Sep 2021 10:22:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC703900002; Sun, 19 Sep 2021 10:22:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 9C1B86B006C for ; Sun, 19 Sep 2021 10:22:04 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 58982181AF5D7 for ; Sun, 19 Sep 2021 14:22:04 +0000 (UTC) X-FDA: 78604537368.39.E71FDFD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id A2E2A10001CC for ; Sun, 19 Sep 2021 14:22:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Y10JfXIf2XYV5MxTL60lbgbnkwxdDgasgVFy6jkggcQ=; b=DJTUwvcrcxBuXG0nLOQsN1yAcz FED0Jm3YW1yuy8vjZkfo0C3lBe/rxXQ0xuCfOncT8Nd9zA05NhM0skgVqn5aqkrBWsJYgb8z8zZcH Eqg026OA/fATdAhnhRwLRO4zZPUxt/Cor4tfkq9Y8ifw8mgYO1P2JIzgz8miiAqK6AJUeMJtO6X0s jOcTY2Iomt7e82CpbcS35TUkM+oTRL0P5UTdR7j3y0r2LLbPtfhBIgRdkdLIxtNUyv5MKItnIERrr iUFiH0gagOs1Kki7vNiZiGIwtn+DsOE5PBkn0bz+zM8V4u9cxkCRqmC4rFBOhs1Y5e+4ZQ+8+jmXB 7O7AmDxg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRxhJ-001vRq-1l; Sun, 19 Sep 2021 14:21:44 +0000 Date: Sun, 19 Sep 2021 15:21:37 +0100 From: Matthew Wilcox To: Oleksandr Natalenko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Miaohe Lin , Michal Hocko , Mel Gorman , Stephen Rothwell , David Laight Subject: Re: [RFC v2 PATCH 1/3] mm: add PG2KB/KB2PG helper macros Message-ID: References: <20210919131248.489798-1-oleksandr@natalenko.name> <20210919131248.489798-2-oleksandr@natalenko.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210919131248.489798-2-oleksandr@natalenko.name> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A2E2A10001CC X-Stat-Signature: xm613hecexs465yyahmazxk7a5ezowk6 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DJTUwvcr; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1632061323-62962 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 19, 2021 at 03:12:46PM +0200, Oleksandr Natalenko wrote: > +#define PG2KB(x) ((x) << (PAGE_SHIFT - 10)) > +#define KB2PG(x) ((x) >> (PAGE_SHIFT - 10)) This is not an improvement.