From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 044DAC433F5 for ; Fri, 17 Sep 2021 00:03:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 802A061019 for ; Fri, 17 Sep 2021 00:03:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 802A061019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 05C846B0071; Thu, 16 Sep 2021 20:03:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00BEB6B0072; Thu, 16 Sep 2021 20:03:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3D836B0073; Thu, 16 Sep 2021 20:03:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id D525A6B0071 for ; Thu, 16 Sep 2021 20:03:33 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9E6A32DD93 for ; Fri, 17 Sep 2021 00:03:33 +0000 (UTC) X-FDA: 78595116306.32.9E56A41 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 52B497001706 for ; Fri, 17 Sep 2021 00:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631837012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lXg7b67tonaDwOcYQzrzVEci7F/ax354VR4+gAw8iYI=; b=Ff3M2R5Cpeus88jnibeiXvj0Ly5fjiDma0DYeLfyU6UFMGGDQVhqOVoyxIQ1/77IvrZOmu sPCeg1I+NIX+Ry5Ec6wLEfMkJMwEiQfDmZ3Rp9WA16OAaRxd4n0tsL2gLjK0eClHGEjPil URICuQDt5ZUVftGsujqmeurIXCH1GbU= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-qCE9W_mXMGCZqKuacoNvvA-1; Thu, 16 Sep 2021 20:03:31 -0400 X-MC-Unique: qCE9W_mXMGCZqKuacoNvvA-1 Received: by mail-qv1-f71.google.com with SMTP id l18-20020a056214039200b0037e4da8b408so76541272qvy.6 for ; Thu, 16 Sep 2021 17:03:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lXg7b67tonaDwOcYQzrzVEci7F/ax354VR4+gAw8iYI=; b=ppjAJ1i5vykNhHiSt9pcnXJrmoVhKF6AcDZ8L6xQcBYimP9HX4FvVhwc90/S3VW9u8 nDTFDNnlxMGvwx7p4V+st6NHxH32W3JNAXGZlQBxNXdJ5XWAGiE/E5ErdbiqW9+buQW4 zdyw+hcxlcCGteAKHDopaR98nOPaCMS4jbOUWYLY/q9D8jKZUha+LWykrqYdUN8p1KqD +zOH61DXwbg9yz3SsTxFhLID063WTs2qNJ9BAJ5GhJuhPdv6TIIKj+P3TuRgLHT0diLN v1xQXPV6eZwu7bVamUUV7V9zm7SBqwubLiUarOpgm0oyrIijy5AlslnOinvRSUoqFQyf 0dUg== X-Gm-Message-State: AOAM531J5L4h6sdHTvkoGFZlIduZTm9jkU60JL93ydGyOitzbVyijAdT dbJNLKV9ZCYhXQoJomio8OIFuda59nz/uRIjZ44h1KwAdA/QztMXki9LvvX3JRTaz2GDmJpA147 v1neoXfXOluA= X-Received: by 2002:a05:622a:1654:: with SMTP id y20mr7636916qtj.261.1631837011124; Thu, 16 Sep 2021 17:03:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5HqNXcmWu8ASICsYZLOr7H/ZB2oG46qRxR0r/3NUlV8Qz8QHL68CNahUKalxm+iOB5UCrrw== X-Received: by 2002:a05:622a:1654:: with SMTP id y20mr7636908qtj.261.1631837010898; Thu, 16 Sep 2021 17:03:30 -0700 (PDT) Received: from t490s ([2607:fea8:56a2:9100::d35a]) by smtp.gmail.com with ESMTPSA id d12sm3547474qka.60.2021.09.16.17.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 17:03:30 -0700 (PDT) Date: Thu, 16 Sep 2021 20:03:28 -0400 From: Peter Xu To: John Hubbard Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz Subject: Re: [PATCH] mm/hugetlb: Drop __unmap_hugepage_range definition from hugetlb.h Message-ID: References: <20210916212816.86838-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 52B497001706 X-Stat-Signature: a4bmfk6qj19944ywcux5r6spiwhg8tyu Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ff3M2R5C; spf=none (imf02.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1631837013-636483 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 16, 2021 at 03:57:38PM -0700, John Hubbard wrote: > On 9/16/21 14:28, Peter Xu wrote: > > Drop it in the header since it's only used in hugetlb.c. > > Hi Peter, Hi, John, > > Tiny documentation tweak: could the above line please be changed to > something approximately like this: > > "Remove __unmap_hugepage_range() from the header file, because it is > only used in the .c file." > > ? Sure thing. > > Because: "drop it in" is so close to "drop it into" (which means, "add > it to"), that it's actually reading a lot like the opposite of what you > intend to say. > > > > > Suggested-by: Mike Kravetz > > Signed-off-by: Peter Xu > > --- > > include/linux/hugetlb.h | 10 ---------- > > mm/hugetlb.c | 6 +++--- > > 2 files changed, 3 insertions(+), 13 deletions(-) > > > The change itself looks accurate for the current top of tree, so: > > Reviewed-by: John Hubbard Thanks! -- Peter Xu