From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD7D9C433FE for ; Tue, 14 Sep 2021 20:23:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5C7486117A for ; Tue, 14 Sep 2021 20:23:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C7486117A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9397B6B006C; Tue, 14 Sep 2021 16:23:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E9556B0072; Tue, 14 Sep 2021 16:23:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D7CC6B0073; Tue, 14 Sep 2021 16:23:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 6B2136B006C for ; Tue, 14 Sep 2021 16:23:22 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DFFC51820C7BC for ; Tue, 14 Sep 2021 20:23:21 +0000 (UTC) X-FDA: 78587303802.25.6EE5435 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf04.hostedemail.com (Postfix) with ESMTP id 7AB9550000A6 for ; Tue, 14 Sep 2021 20:23:21 +0000 (UTC) Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 18EKMujD020560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 16:22:57 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 97AD815C3424; Tue, 14 Sep 2021 16:22:56 -0400 (EDT) Date: Tue, 14 Sep 2021 16:22:56 -0400 From: "Theodore Ts'o" To: Muchun Song Cc: willy@infradead.org, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, shakeelb@google.com, guro@fb.com, shy828301@gmail.com, alexs@kernel.org, richard.weiyang@gmail.com, david@fromorbit.com, trond.myklebust@hammerspace.com, anna.schumaker@netapp.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, zhengqi.arch@bytedance.com, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, smuchun@gmail.com Subject: Re: [PATCH v3 00/76] Optimize list lru memory consumption Message-ID: References: <20210914072938.6440-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210914072938.6440-1-songmuchun@bytedance.com> Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=none (imf04.hostedemail.com: domain of tytso@mit.edu has no SPF policy when checking 18.9.28.11) smtp.mailfrom=tytso@mit.edu X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7AB9550000A6 X-Stat-Signature: bq3rps8cj4m6kb559snokr4mpoxsdbmx X-HE-Tag: 1631651001-479935 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 14, 2021 at 03:28:22PM +0800, Muchun Song wrote: > So we have to convert to new API for all filesystems, which is done in > one patch. Some filesystems are easy to convert (just replace > kmem_cache_alloc() to alloc_inode_sb()), while other filesystems need to > do more work. >From what I can tell, three are 54 file systems for which it was a trivial one-line change, and two (f2fs and nfs42) that were a tad bit more complex. > In order to make it easy for maintainers of different > filesystems to review their own maintained part, I split the patch into > patches which are per-filesystem in this version. I am not sure if this > is a good idea, because there is going to be more commits. What I'd actually suggest is that you combine all of the trivial file system changes into a single commit, and keep the two more complex changes for f2fs and nfs42 in separate commits. Acked-by: Theodore Ts'o ... for the ext4 related change. - Ted