From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DBAAC433EF for ; Fri, 24 Sep 2021 22:09:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B561761212 for ; Fri, 24 Sep 2021 22:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B561761212 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E05EC6B0071; Fri, 24 Sep 2021 18:09:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB47D6B0072; Fri, 24 Sep 2021 18:09:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCACA900002; Fri, 24 Sep 2021 18:09:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id C15FB6B0071 for ; Fri, 24 Sep 2021 18:09:14 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6B6FA1817C788 for ; Fri, 24 Sep 2021 22:09:14 +0000 (UTC) X-FDA: 78623858628.10.9EBA22A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 17874D00009F for ; Fri, 24 Sep 2021 22:09:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=K0aUY6geVtaUrVfiEquZHnhrylfB5RLBx1nuZ8fUEbM=; b=BiBW/iAZMl3+JQqTlfAypM4W4N u3bXUUSUTNrgaWy+MdYVoJZH4t6N8QyDUnmmFUn97ejTKu9sTIHtYvbqNuZvLjiTrDUnrc953dYiq nrKLem/S0pbWRftsvSSDBdJoGDOQwy3zAHg3YWdADHLxX1bGTZiILQjt6P6W+6i5Rkjo9f+KELE5R iNNziPBgexYL8LouIhKycTYVy88GqByEeFEzounbKbi3mQsv0QXVQsEbEZa+RXsrnJcSLe17418Fr 6z+rkzfK5sqE9wpsK0IvIdj966dj9+3f0X5V0WCHxqPI5n4B8qfKUtNSbtq8MRi2LOhhccv6WC0nu 7HiMky+g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTtM5-007drd-Ch; Fri, 24 Sep 2021 22:07:55 +0000 Date: Fri, 24 Sep 2021 23:07:41 +0100 From: Matthew Wilcox To: David Howells Cc: hch@lst.de, trond.myklebust@primarydata.com, Jens Axboe , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, darrick.wong@oracle.com, viro@zeniv.linux.org.uk, jlayton@kernel.org, torvalds@linux-foundation.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/9] mm: Make swap_readpage() void Message-ID: References: <163250387273.2330363.13240781819520072222.stgit@warthog.procyon.org.uk> <163250390413.2330363.3248359518033939175.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <163250390413.2330363.3248359518033939175.stgit@warthog.procyon.org.uk> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 17874D00009F X-Stat-Signature: zwuxz4iokxzidw8njkms3ipomcw16rtz Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="BiBW/iAZ"; dmarc=none; spf=none (imf15.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1632521353-504970 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 24, 2021 at 06:18:24PM +0100, David Howells wrote: > None of the callers of swap_readpage() actually check its return value and, > indeed, the operation may still be in progress, so remove the return value. > > Signed-off-by: David Howells Reviewed-by: Matthew Wilcox (Oracle)