From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74A88C433EF for ; Thu, 9 Sep 2021 08:05:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0875F61132 for ; Thu, 9 Sep 2021 08:05:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0875F61132 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 517086B0071; Thu, 9 Sep 2021 04:05:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C61B900002; Thu, 9 Sep 2021 04:05:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3662D6B0073; Thu, 9 Sep 2021 04:05:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 20E396B0071 for ; Thu, 9 Sep 2021 04:05:47 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C811E274B0 for ; Thu, 9 Sep 2021 08:05:46 +0000 (UTC) X-FDA: 78567301092.37.367579D Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf07.hostedemail.com (Postfix) with ESMTP id 3AB341000098 for ; Thu, 9 Sep 2021 08:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3qrQB6d8ePB9z+YR7DZ4I3k8HfDrD/7XELuX2rFMGOI=; b=HmnBaS1EnmTSlK05RhgfftlS7K 5OYfMBtEm2Whmgf+lIKtnz9u591s1YKoqY6DC+50rVbFumsF2rLIEcAbtugjcHELn52WF4Elhwxqd iGWN8VIKQqC6k/eurIVUZkE+lgumt48EZ36swXJFOmbNpBHpw4SM5yT1SF0t+xQ4nD0HIJZZzKy4w vUdqL9+QHo6T3/1RcnWpfAo45ds+SG7j7UeIQZHARTciMxYrKTKMIlGrnbNJnvSF+uNGR/pLxqdBU iQfg3Yreu/t6kQPWO4hp097Lz6gbvbgOwqdk2ZsnQLpcGmF1H9LmBciPSnfhUyON+fF9LTau50wHH ihT1Y4hw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOF3q-001pJO-6N; Thu, 09 Sep 2021 08:05:30 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5FC763001C7; Thu, 9 Sep 2021 10:05:29 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 49CA429DD60A4; Thu, 9 Sep 2021 10:05:29 +0200 (CEST) Date: Thu, 9 Sep 2021 10:05:29 +0200 From: Peter Zijlstra To: Liam Howlett Cc: Alexei Starovoitov , Andrew Morton , Luigi Rizzo , Yonghong Song , Jason Gunthorpe , Daniel Borkmann , bpf , "linux-mm@kvack.org" , Alexei Starovoitov , Andrii Nakryiko , "kernel-team@fb.com" , "walken@fb.com" Subject: Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock Message-ID: References: <20210908151230.m2zyslt4qrufm4bv@revolver> <20210908172118.n2f4w7epm6hh62zf@ast-mbp.dhcp.thefacebook.com> <20210908105259.c47dcc4e4371ebb5e147ee6e@linux-foundation.org> <20210908180258.yjh62e5oouckar5b@ast-mbp.dhcp.thefacebook.com> <20210908111527.9a611426e257d55ccbbf46eb@linux-foundation.org> <20210908183032.zoh6dj5xh455z47f@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210908183032.zoh6dj5xh455z47f@revolver> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 3AB341000098 X-Stat-Signature: kzknxqnnm87td3deuwadaasd77qe8oqz Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=HmnBaS1E; spf=none (imf07.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none X-HE-Tag: 1631174746-338308 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 08, 2021 at 06:30:52PM +0000, Liam Howlett wrote: > + VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm); NAK.. do not ever use the _is_locked() trainwrecks.