From: Peter Zijlstra <peterz@infradead.org>
To: Liam Howlett <liam.howlett@oracle.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Luigi Rizzo <lrizzo@google.com>, Yonghong Song <yhs@fb.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
"kernel-team@fb.com" <kernel-team@fb.com>,
"walken@fb.com" <walken@fb.com>
Subject: Re: [PATCH mm/bpf v2] mm: bpf: add find_vma_no_check() without lockdep_assert on mm->mmap_lock
Date: Thu, 9 Sep 2021 10:05:29 +0200 [thread overview]
Message-ID: <YTnASdwzG2DS5lrc@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210908183032.zoh6dj5xh455z47f@revolver>
On Wed, Sep 08, 2021 at 06:30:52PM +0000, Liam Howlett wrote:
> + VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_lock), mm);
NAK.. do not ever use the _is_locked() trainwrecks.
next prev parent reply other threads:[~2021-09-09 8:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 4:44 Yonghong Song
2021-09-08 12:20 ` Daniel Borkmann
2021-09-08 13:53 ` Jason Gunthorpe
2021-09-08 14:15 ` Peter Zijlstra
2021-09-08 14:43 ` Luigi Rizzo
2021-09-08 15:12 ` Liam Howlett
2021-09-08 16:09 ` Yonghong Song
2021-09-08 17:09 ` Luigi Rizzo
2021-09-08 17:21 ` Alexei Starovoitov
2021-09-08 17:52 ` Andrew Morton
2021-09-08 18:02 ` Alexei Starovoitov
2021-09-08 18:15 ` Andrew Morton
2021-09-08 18:20 ` Alexei Starovoitov
2021-09-08 18:30 ` Liam Howlett
2021-09-08 18:45 ` Yonghong Song
2021-09-08 18:49 ` Jason Gunthorpe
2021-09-08 19:11 ` Yonghong Song
2021-09-08 23:33 ` Jason Gunthorpe
2021-09-09 5:50 ` Yonghong Song
2021-09-09 8:05 ` Peter Zijlstra [this message]
2021-09-08 18:43 ` Liam Howlett
2021-09-08 19:42 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTnASdwzG2DS5lrc@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jgg@ziepe.ca \
--cc=kernel-team@fb.com \
--cc=liam.howlett@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lrizzo@google.com \
--cc=walken@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox