From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FA3C433EF for ; Thu, 9 Sep 2021 01:40:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22C376113E for ; Thu, 9 Sep 2021 01:40:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 22C376113E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A6F176B0071; Wed, 8 Sep 2021 21:40:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1EB86B0072; Wed, 8 Sep 2021 21:40:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BEC2900002; Wed, 8 Sep 2021 21:40:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 78A6B6B0071 for ; Wed, 8 Sep 2021 21:40:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1C5D5183381FE for ; Thu, 9 Sep 2021 01:40:02 +0000 (UTC) X-FDA: 78566329044.21.C58C3A2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 4A2546001980 for ; Thu, 9 Sep 2021 01:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZyX4M69HKrevcTDt5hkWJXKw8C4aMMkVnPFPlPbnHVA=; b=XSCXbbhFc90w6nzz53Uml5cnwp Ac57r5+rJEYXxCWxALnofzk3jBSYfJNYWAevVU2V70oToF9xj5t62Gsb7g5JhTUDaEJ/3y43NdcEt jWXfJ906hU58Rxfaq7eSG/tPvv67X7GDy8dR1wD/F9GwM5yDgk/Oz+BKeINeIb2b5JWbULrtcVxVu Sbj+IYGNwf01MhxKV8h5G/wt9kGya3E93k88+xV45ycHHdpJMU8p6L/YlO8Zppfi2QAHD7LGlC7LF SpiAIzRxdTM7xvjrVGmX0u5RFf3XV+2ZjQpgxVNBjFIRMOBnLOdA1yoqq7pdOdSUDwHWa4xTSvBeO uWsSrUgQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mO91J-009LJY-W0; Thu, 09 Sep 2021 01:38:35 +0000 Date: Thu, 9 Sep 2021 02:38:29 +0100 From: Matthew Wilcox To: Yonghong Song Cc: bpf@vger.kernel.org, linux-mm@kvack.org, Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , kernel-team@fb.com, Luigi Rizzo , Liam Howlett Subject: Re: [PATCH mm/bpf v3] mm: bpf: add find_vma_non_owner() without lockdep_assert on mm->mmap_lock Message-ID: References: <20210908224438.391816-1-yhs@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210908224438.391816-1-yhs@fb.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4A2546001980 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XSCXbbhF; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: rr3izrej64hx8o7pabq1o5fa19a1fthm X-HE-Tag: 1631151601-287882 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 08, 2021 at 03:44:38PM -0700, Yonghong Song wrote: > +extern struct vm_area_struct * find_vma_non_owner(struct mm_struct * mm, > + unsigned long addr); - extern is deprecated - no space between the '*' and 'mm'. - no space between the '*' and the function name. > +struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr) > +{ > + lockdep_assert_held(&mm->mmap_lock); > + return find_vma_non_owner(mm, addr); > +} > + > EXPORT_SYMBOL(find_vma); No blank line between the closing '}' and the EXPORT_SYMBOL.