From: Matthew Wilcox <willy@infradead.org>
To: Yonghong Song <yhs@fb.com>
Cc: bpf@vger.kernel.org, linux-mm@kvack.org,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@fb.com, Luigi Rizzo <lrizzo@google.com>,
Liam Howlett <liam.howlett@oracle.com>
Subject: Re: [PATCH mm/bpf v3] mm: bpf: add find_vma_non_owner() without lockdep_assert on mm->mmap_lock
Date: Thu, 9 Sep 2021 02:38:29 +0100 [thread overview]
Message-ID: <YTlllQenVPeNNxIF@casper.infradead.org> (raw)
In-Reply-To: <20210908224438.391816-1-yhs@fb.com>
On Wed, Sep 08, 2021 at 03:44:38PM -0700, Yonghong Song wrote:
> +extern struct vm_area_struct * find_vma_non_owner(struct mm_struct * mm,
> + unsigned long addr);
- extern is deprecated
- no space between the '*' and 'mm'.
- no space between the '*' and the function name.
> +struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
> +{
> + lockdep_assert_held(&mm->mmap_lock);
> + return find_vma_non_owner(mm, addr);
> +}
> +
> EXPORT_SYMBOL(find_vma);
No blank line between the closing '}' and the EXPORT_SYMBOL.
next prev parent reply other threads:[~2021-09-09 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 22:44 Yonghong Song
2021-09-09 1:38 ` Matthew Wilcox [this message]
2021-09-09 5:48 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTlllQenVPeNNxIF@casper.infradead.org \
--to=willy@infradead.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=liam.howlett@oracle.com \
--cc=linux-mm@kvack.org \
--cc=lrizzo@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox