From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD125C433EF for ; Tue, 7 Sep 2021 17:01:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 72A5061090 for ; Tue, 7 Sep 2021 17:01:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 72A5061090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BDF996B0071; Tue, 7 Sep 2021 13:01:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8E8D6B0072; Tue, 7 Sep 2021 13:01:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5805900002; Tue, 7 Sep 2021 13:01:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 930F86B0071 for ; Tue, 7 Sep 2021 13:01:40 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 49D162DD83 for ; Tue, 7 Sep 2021 17:01:40 +0000 (UTC) X-FDA: 78561393960.12.E500D60 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf16.hostedemail.com (Postfix) with ESMTP id 8F83CF0000B3 for ; Tue, 7 Sep 2021 17:00:38 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id u13-20020a17090abb0db0290177e1d9b3f7so1943942pjr.1 for ; Tue, 07 Sep 2021 10:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=A0sxVmfddG/iMYR9MPhr5LGq+Hc/rulYoKrv0lmk57k=; b=imvK2NfqcweTnq3DfQ3kxb1hyyCHKaJdKjFFwmOFRNGcCgTtZXib10r3SXVdX1Z5Zt Kt14UJeK58D6y9CsD5v7TZqu2/sd20G9+0vs2OYRr8FGpQQ1FWzWh1ikUF/TG8DDkyp0 F0YDBFXr2ZX4jkAZRc3ZlmB3vjDSLMZ+u8QirCOPIIHgiDF+hzptraPt4Akrd159DF7P +b60+gZLISbc5rHbH9LOExA+6YeVK+nFwZOyUw37yjrfvIUq8ljRgh16mCAua3Upkbyd EoMyC4xOdUhiEVTkEOKy8zk5EZ0cDxt4dZet2AYVdDEZTxF/MbZDftoJ8niCrKZDCf9I yRzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=A0sxVmfddG/iMYR9MPhr5LGq+Hc/rulYoKrv0lmk57k=; b=L8tKV01yVxSR7wd8RqJzU90CEi6WLrKhKA2ef1CshH/TufnfH6hZAKVoVOWNx0MJjM tTZW3/zcX/7+xohMTX8eIVF+WZQHCGQQf3WIUSDaCQkFfXCpJJhJUx/zLpczkPQlwhjt BMytS8cIumdtph/3DMn1OU768AIcT4ggq8Kcmxn3q5LbVnhXpb+d9GL9NJSNKzqw/m/2 BHwSvqY7YVH80Q5i/V1w1rJZWTEDCDiuZDoeSie2VPh/19ptH/WW+BZ6TOj4RIEI1ED7 JLZUtIAFcCz/VNpuUGBwZeqSn/b8uZBMINzfSfzkY8w7M/RqBX+4fgoTR+qCzQKU1LMH sbig== X-Gm-Message-State: AOAM533I/Nuh4O3QhEZVZf5VPMZ5NvxU1/oL/YFwCHoCA/dldnIBAXNa jmIo3zAbBnSL9g7fFRndUbY= X-Google-Smtp-Source: ABdhPJx0GYgkTG9aSzp+VK4h1B583iwbvg8d5XIm7VPSBrTdzAq48wrj6nO/RR1gnckHyHtksmcp2g== X-Received: by 2002:a17:90a:55cb:: with SMTP id o11mr5682682pjm.244.1631034037561; Tue, 07 Sep 2021 10:00:37 -0700 (PDT) Received: from google.com ([2620:15c:211:201:998a:2486:f524:8502]) by smtp.gmail.com with ESMTPSA id i8sm11545909pfo.117.2021.09.07.10.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 10:00:37 -0700 (PDT) Date: Tue, 7 Sep 2021 10:00:35 -0700 From: Minchan Kim To: Jaewon Kim Cc: Christoph Hellwig , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , YongTaek Lee , "jaewon31.kim@gmail.com" Subject: Re: (2) [PATCH] zram_drv: allow reclaim on bio_alloc Message-ID: References: <20210906052926.6007-1-jaewon31.kim@samsung.com> <20210906091448epcms1p6bcc1f11b0da18e215219e6868ed07914@epcms1p6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210906091448epcms1p6bcc1f11b0da18e215219e6868ed07914@epcms1p6> Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=imvK2Nfq; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf16.hostedemail.com: domain of minchankim@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=minchankim@gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8F83CF0000B3 X-Stat-Signature: 6jygx6t8uw14zqqxx8ankgwrm9z13asw X-HE-Tag: 1631034038-960210 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Jaewon, On Mon, Sep 06, 2021 at 06:14:48PM +0900, Jaewon Kim wrote: > > > > > >--------- Original Message --------- > >Sender : Christoph Hellwig > >Date : 2021-09-06 17:39 (GMT+9) > >Title : Re: [PATCH] zram_drv: allow reclaim on bio_alloc > > > >On Mon, Sep 06, 2021 at 02:29:26PM +0900, Jaewon Kim wrote: > >> The read_from_bdev_async is not called on atomic context. So GFP_NOIO is > >> available rather than GFP_ATOMIC. If there were reclaimable pages with > >> GFP_NOIO, we can avoid allocation failure and page fault failure. > >> > >> Reported-by: Yong-Taek Lee > >> Signed-off-by: Jaewon Kim Looks reasonable to me. Feel free to add after dealing with Christoph's comment. Acked-by: Minchan Kim Thank you. > >> --- > >> drivers/block/zram/zram_drv.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > >> index fcaf2750f68f..53be528a39a2 100644 > >> --- a/drivers/block/zram/zram_drv.c > >> +++ b/drivers/block/zram/zram_drv.c > >> @@ -587,7 +587,7 @@ static int read_from_bdev_async(struct zram *zram, struct bio_vec *bvec, > >> { > >> struct bio *bio; > >> > >> - bio = bio_alloc(GFP_ATOMIC, 1); > >> + bio = bio_alloc(GFP_NOIO|__GFP_HIGHMEM, 1); > > > >Passing __GFP_HIGHMEM to bio_alloc does not make any sense whatsoever. > > > Correct, let me remove __GFP_HIGHMEM if I send v2 patch. > Thank you