From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C07A7C433FE for ; Tue, 7 Sep 2021 07:24:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5E7A761100 for ; Tue, 7 Sep 2021 07:24:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5E7A761100 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8EADF6B0071; Tue, 7 Sep 2021 03:23:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89AC0900003; Tue, 7 Sep 2021 03:23:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B2C7900002; Tue, 7 Sep 2021 03:23:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 6EC2F6B0071 for ; Tue, 7 Sep 2021 03:23:59 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1610F181AEF31 for ; Tue, 7 Sep 2021 07:23:59 +0000 (UTC) X-FDA: 78559938198.10.D841A24 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf24.hostedemail.com (Postfix) with ESMTP id BFA4EB00009F for ; Tue, 7 Sep 2021 07:23:58 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id ADA4F6109D; Tue, 7 Sep 2021 07:23:56 +0000 (UTC) Date: Tue, 7 Sep 2021 08:23:54 +0100 From: Catalin Marinas To: Naohiro Aota Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org Subject: Re: [PATCH] mm/kmemleak: allow __GFP_NOLOCKDEP passed to kmemleak's gfp Message-ID: References: <20210907055659.3182992-1-naohiro.aota@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210907055659.3182992-1-naohiro.aota@wdc.com> Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of cmarinas@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BFA4EB00009F X-Stat-Signature: 6oqt7nd1g3p1mtzt8prbp89wezy5n78z X-HE-Tag: 1630999438-275103 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 07, 2021 at 02:56:59PM +0900, Naohiro Aota wrote: > In a memory pressure situation, I'm seeing the lockdep WARNING below. > Actually, this is similar to a known false positive which is already > addressed by commit 6dcde60efd94 ("xfs: more lockdep whackamole with > kmem_alloc*"). > > This warning still persists because it's not from kmalloc() itself but > from an allocation for kmemleak object. While kmalloc() itself suppress > the warning with __GFP_NOLOCKDEP, gfp_kmemleak_mask() is dropping the > flag for the kmemleak's allocation. > > Allow __GFP_NOLOCKDEP to be passed to kmemleak's allocation, so that the > warning for it is also suppressed. > > ====================================================== > WARNING: possible circular locking dependency detected > 5.14.0-rc7-BTRFS-ZNS+ #37 Not tainted Acked-by: Catalin Marinas