From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65822C433F5 for ; Fri, 3 Sep 2021 01:43:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4395A60EE6 for ; Fri, 3 Sep 2021 01:43:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4395A60EE6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9EC448D0002; Thu, 2 Sep 2021 21:43:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9743B8D0001; Thu, 2 Sep 2021 21:43:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83BC58D0002; Thu, 2 Sep 2021 21:43:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 6FCEC8D0001 for ; Thu, 2 Sep 2021 21:43:46 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3171C253B6 for ; Fri, 3 Sep 2021 01:43:46 +0000 (UTC) X-FDA: 78544565652.24.C3E5190 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id AFAE2900013E for ; Fri, 3 Sep 2021 01:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=thtGYqZ0DakkE8JK0/MwinDZlqRB0FWqqYnSaIBuUWI=; b=Af8YOyBQTqHQdOVI4oDU63HHVB Tou7+9iVzE2V4PwtBA4/uNfouZvI6LpHKIJeBXnk/N+FLyfI0oBxSKFPJNBmp7+2ozg/trGlTlqaI 9Mza0WWqFpxZ0tbrLPdCNzqAPMxmLXs1RecLno1pyX89i6ep1Y/pwDrjMTvEtx1KEbJzDwmLIj/IF UcXG2fUkyBFzLXulLJflnytQPRWD5VNX4lePXMmwVP+rWDpOdwr6HgzrGcFvKnjQKul0u1Gi3MeZb xOpqMx5tglBsTY/meHMtUJnsB6aTPKnjMAUPESxFEDhpjiL/mlFjMGg41SH0mNWUhYfmg0PPWo4cH 3/QR15+g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLyE0-0042jW-BY; Fri, 03 Sep 2021 01:43:00 +0000 Date: Fri, 3 Sep 2021 02:42:36 +0100 From: Matthew Wilcox To: Liam Howlett Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Steven Rostedt , Michel Lespinasse , Vlastimil Babka Subject: Re: [PATCH] mmap_lock: Change trace and locking order Message-ID: References: <20210903013521.1802774-1-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210903013521.1802774-1-Liam.Howlett@oracle.com> X-Rspamd-Queue-Id: AFAE2900013E Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Af8YOyBQ; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam01 X-Stat-Signature: atp7h1wn469guhocjaciig5etoh3gnxk X-HE-Tag: 1630633425-571346 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 03, 2021 at 01:35:31AM +0000, Liam Howlett wrote: > Print to the trace log before releasing the lock to avoid racing with > other trace log printers of the same lock type. Aren't you missing mmap_read_unlock_non_owner()?