From: Michal Hocko <mhocko@suse.com>
To: Feng Tang <feng.tang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@techsingularity.net>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/page_alloc: detect allocation forbidden by cpuset and bail out early
Date: Mon, 13 Sep 2021 13:45:51 +0200 [thread overview]
Message-ID: <YT8576cL4tSqmUKI@dhcp22.suse.cz> (raw)
In-Reply-To: <20210913113423.GC56674@shbuild999.sh.intel.com>
On Mon 13-09-21 19:34:23, Feng Tang wrote:
> On Mon, Sep 13, 2021 at 11:15:54AM +0200, Michal Hocko wrote:
[...]
> > > +/* Whether the 'nodes' are all movable nodes */
> > > +static inline bool movable_only_nodes(nodemask_t *nodes)
> > > +{
> > > + struct zonelist *zonelist;
> > > + struct zoneref *z;
> > > +
> > > + zonelist = &(first_online_pgdat())->node_zonelists[ZONELIST_FALLBACK];
> >
> > This will work but it just begs a question why you haven't chosen a node
> > from the given nodemask. So I believe it would be easier to read if you
> > did
> > zonelist = NODE_DATA(first_node(nodes))->node_zonelists[ZONELIST_FALLBACK]
>
> This was also my first try to get the 'zonelist', but from the
> update_nodemask(), the nodemask could be NULL.
I guess you meant to say s@NULL@empty@
While this complicates things a bit it is nothing really hard to work
around. You simply check for nodes_empty() and return false because such
a nodemask cannot by definition be movable only.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-09-13 11:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 7:38 Feng Tang
2021-09-13 9:15 ` Michal Hocko
2021-09-13 11:34 ` Feng Tang
2021-09-13 11:45 ` Michal Hocko [this message]
2021-09-13 12:12 ` Feng Tang
2021-09-13 9:40 ` kernel test robot
2021-09-13 10:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YT8576cL4tSqmUKI@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=feng.tang@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=mgorman@techsingularity.net \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox