From: Christoph Hellwig <hch@infradead.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>,
linux-mm@kvack.org, linux-rdma@vger.kernel.org,
akpm@linux-foundation.org, jglisse@redhat.com,
yishaih@nvidia.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/hmm: bypass devmap pte when all pfn requested flags are fulfilled
Date: Fri, 27 Aug 2021 18:45:43 +0100 [thread overview]
Message-ID: <YSkkx6Tci3n+qN54@infradead.org> (raw)
In-Reply-To: <20210827162852.GL1200268@ziepe.ca>
On Fri, Aug 27, 2021 at 01:28:52PM -0300, Jason Gunthorpe wrote:
> > + /*
> > + * just bypass devmap pte such as DAX page when all pfn requested
> > + * flags(pfn_req_flags) are fulfilled.
> > + */
> > + if (pte_devmap(pte))
> > + goto out;
>
> I liked your ealier version better where this was added to the
> pte_special test - logically this is about disambiguating the
> pte_special and the devmap case as they are different things.
Yes, I think that is much more logical. Also please capitalize the
first word in multi-line comments.
prev parent reply other threads:[~2021-08-27 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 14:45 Li Zhijian
2021-08-27 16:28 ` Jason Gunthorpe
2021-08-27 17:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSkkx6Tci3n+qN54@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizhijian@cn.fujitsu.com \
--cc=stable@vger.kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox