From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E06C4338F for ; Tue, 24 Aug 2021 02:06:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7AC82613AB for ; Tue, 24 Aug 2021 02:06:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7AC82613AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E5C286B006C; Mon, 23 Aug 2021 22:06:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0C366B0071; Mon, 23 Aug 2021 22:06:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFAFE6B0072; Mon, 23 Aug 2021 22:06:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id B365F6B006C for ; Mon, 23 Aug 2021 22:06:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 43687181C98F9 for ; Tue, 24 Aug 2021 02:06:50 +0000 (UTC) X-FDA: 78508335780.12.7C96295 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf02.hostedemail.com (Postfix) with ESMTP id E4CFB7001703 for ; Tue, 24 Aug 2021 02:06:49 +0000 (UTC) Received: by mail-qk1-f180.google.com with SMTP id c10so18958955qko.11 for ; Mon, 23 Aug 2021 19:06:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JAUUnTgkoa3k12aTtTd1I7GW9Zir2hN+aG0xsiNu28Q=; b=GfpH8t1L88+z5R/m/SkhUz7O3KgqY4ofC6TMgH+SoGQAEPKi2E3m3AdEEEEs2fUtk5 A47xQxO+jl3lANqkX0JNCEI9hd8Ta4u5QR3HY+1lXJ6FhxgvnNtn47JKNOwhik3adU0+ rXLTs5tWQiQ3uct7gp9RhDGkiF4lXxE6DTAHOARNdHNr6bnbgS0q6iL17G4P93a3+29g x6/fP1eSACn4M2FBipyYQyAc49iEJRXI5HmYq32pR/UqO3GYUIPW47eVGX2iY2h+mWE+ Zb1VjslVSlURyTboCRDsMGbS/jjOyx0Mp4+QINwGXzujnZuLyV5aa9Gh9s5ccSxe5Qqn njnA== X-Gm-Message-State: AOAM530bw6uu93bLVo5flJ0C8IdgmparPVC5BiwS1eA/1jm4MDiNHGlY LRQySlmuD3HQEPLtZVzenJ4= X-Google-Smtp-Source: ABdhPJxWSN1E85hQycCFZ4I7YEf3eAqWxQmhtdWFxoWw9Vgl7IjjL9h4/Erx3OVVYmABtuSgvilAZw== X-Received: by 2002:a37:8044:: with SMTP id b65mr23838872qkd.295.1629770809337; Mon, 23 Aug 2021 19:06:49 -0700 (PDT) Received: from fedora (pool-173-68-57-129.nycmny.fios.verizon.net. [173.68.57.129]) by smtp.gmail.com with ESMTPSA id q14sm9636827qkl.44.2021.08.23.19.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 19:06:48 -0700 (PDT) Date: Mon, 23 Aug 2021 22:06:47 -0400 From: Dennis Zhou To: Ritesh Harjani Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dennis Zhou , Tejun Heo , Christoph Lameter Subject: Re: [PATCHv2 1/2] kernel/workqueue: Make schedule_on_each_cpu as EXPORT_SYMBOL_GPL Message-ID: References: <5afc2a0c4da65e71ccf24fe65396710d34fc662e.1629751104.git.riteshh@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5afc2a0c4da65e71ccf24fe65396710d34fc662e.1629751104.git.riteshh@linux.ibm.com> X-Rspamd-Queue-Id: E4CFB7001703 Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf02.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com X-Rspamd-Server: rspam01 X-Stat-Signature: atiytr5r5osh34z5nhj1fww1mm7aodu9 X-HE-Tag: 1629770809-371292 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, On Tue, Aug 24, 2021 at 02:12:29AM +0530, Ritesh Harjani wrote: > Make schedule_on_each_cpu as EXPORT_SYMBOL_GPL > > Signed-off-by: Ritesh Harjani > --- > [v1 -> v2]: Use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL > > kernel/workqueue.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/workqueue.c b/kernel/workqueue.c > index f148eacda55a..993f8983186d 100644 > --- a/kernel/workqueue.c > +++ b/kernel/workqueue.c > @@ -3309,6 +3309,7 @@ int schedule_on_each_cpu(work_func_t func) > free_percpu(works); > return 0; > } > +EXPORT_SYMBOL_GPL(schedule_on_each_cpu); > > /** > * execute_in_process_context - reliably execute the routine with user context > -- > 2.31.1 > I think you missed the point of Christoph's comment. I agree with him and don't think a test justifies exporting of this particular function. Thanks, Dennis