From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE0EC432BE for ; Wed, 1 Sep 2021 10:31:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 59B6C6023E for ; Wed, 1 Sep 2021 10:31:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 59B6C6023E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C7F938D0001; Wed, 1 Sep 2021 06:31:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2F676B0071; Wed, 1 Sep 2021 06:31:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B45A08D0001; Wed, 1 Sep 2021 06:31:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id A58AA6B006C for ; Wed, 1 Sep 2021 06:31:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5AB1118095BA7 for ; Wed, 1 Sep 2021 10:31:42 +0000 (UTC) X-FDA: 78538638444.10.174DB1B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf29.hostedemail.com (Postfix) with ESMTP id DDE5B9000249 for ; Wed, 1 Sep 2021 10:31:41 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id C2DFD202B3; Wed, 1 Sep 2021 10:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630492300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EO3JsQqvzkTHmENKGP7Sv2zsa9Ofobc6JGxvJ/VjjBE=; b=TAZQ9GQ46WKV1lDwWzq/TwKyqgsnYxzNbxk/WDr4KnUScH5O/iNRJkpMy5obw1wL5X2/7/ gzUfhgCX/qs/TY9bn6b8o/2SBA+s0m5gvT8GlrJ2hh63mneZ3HPG3NseoVFX3gwA97wftB ZDl+K3uGckg21CEEEBlDSGeDpU7LOtQ= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id DBD4AA3B95; Wed, 1 Sep 2021 10:31:39 +0000 (UTC) Date: Wed, 1 Sep 2021 12:31:36 +0200 From: Michal Hocko To: Oleksandr Natalenko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Matthew Wilcox , Greg Kroah-Hartman , Miaohe Lin , Mel Gorman , Stephen Rothwell Subject: Re: [RFC PATCH 1/1] mm: provide one common K(x) macro Message-ID: References: <20210901092149.994791-1-oleksandr@natalenko.name> <20210901092149.994791-2-oleksandr@natalenko.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210901092149.994791-2-oleksandr@natalenko.name> Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=TAZQ9GQ4; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DDE5B9000249 X-Stat-Signature: qgi85i3a9xrb9kn5eaw9yaqb9tzashre X-HE-Tag: 1630492301-908147 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 01-09-21 11:21:49, Oleksandr Natalenko wrote: > There are various places where the K(x) macro is defined. This commit > gets rid of multiple definitions and provides a common one. > > This doesn't solve open-coding this macro in various other places. This > should be addressed by another subsequent commit. Why is this an improvement? You are adding a header file for a single macro which sounds like an overkill. The overall net outcome is added lines of code. It is not like K() or any of its variant is adding a maintenance burden due to code duplication. So why do we want to change the existing state? -- Michal Hocko SUSE Labs