From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294ADC43214 for ; Wed, 18 Aug 2021 00:13:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 962F861058 for ; Wed, 18 Aug 2021 00:13:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 962F861058 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CB6C48D0001; Tue, 17 Aug 2021 20:13:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C66FD6B0072; Tue, 17 Aug 2021 20:13:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5F3B8D0001; Tue, 17 Aug 2021 20:13:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 98CD56B0071 for ; Tue, 17 Aug 2021 20:13:11 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 40E93250A2 for ; Wed, 18 Aug 2021 00:13:11 +0000 (UTC) X-FDA: 78486276582.36.659AAEB Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf06.hostedemail.com (Postfix) with ESMTP id F0258801CFBD for ; Wed, 18 Aug 2021 00:13:10 +0000 (UTC) Received: by mail-oi1-f170.google.com with SMTP id r5so1878131oiw.7 for ; Tue, 17 Aug 2021 17:13:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=++h8bUGhJWF7B6yyYyoh0nKkVdcF8eCL74y7f9GeZ4Y=; b=WmnaBgTNUyDU1jrl0bKY91lyuXm+FhJI6bLJTfjXuwqD8PAlFZHZyeBTcNcy0QFat5 INLXGSTIjNPw4Rmr/zANhsHLkuheZKwz5M51mn550jH5CkwH+Qp498qLd0igfrgg+9J1 iuFDpooFInXvAi3vsGTroUqEMMXSumL/jXfPn2ZMmeH4jIO60LKKnVhQ6BzX+deVf/Qh 3BBZJO9zy7hQ6S9zB7hb+CWjroxqsV6IjBYbE/JlHalkXyxX/En6Un9PUehtn7mCjAnI TXhYn7Z1zBNAT4imGorchu+xeh1dDqy7X84Jefbfo92w6uSTV/estlyXcJCQvCESCuzB VJhQ== X-Gm-Message-State: AOAM530wvlynDW0tLFoZ81gRLFldUI4o/gYFrcBxZO3PNNWECtZ/aHtS 78zxRLzdttiSWH32XwSwBA== X-Google-Smtp-Source: ABdhPJyJOifM/j6dYvgpX8URevK/gXq/UxE91n+1ytfa41bf6TcZ7UPHLnQ6y0p94fi4QGOLVqhW9w== X-Received: by 2002:aca:b984:: with SMTP id j126mr4666629oif.32.1629245590250; Tue, 17 Aug 2021 17:13:10 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k16sm738270oor.16.2021.08.17.17.13.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Aug 2021 17:13:09 -0700 (PDT) Received: (nullmailer pid 1094241 invoked by uid 1000); Wed, 18 Aug 2021 00:13:07 -0000 Date: Tue, 17 Aug 2021 19:13:07 -0500 From: Rob Herring To: Mike Rapoport Cc: Borislav Petkov , linux-mm@kvack.org, linux-mips@vger.kernel.org, "Kirill A . Shutemov" , Marc Zyngier , Thomas Bogendoerfer , Peter Zijlstra , Greg Kroah-Hartman , Paul Walmsley , Will Deacon , x86@kernel.org, "H. Peter Anvin" , "Rafael J. Wysocki" , Andy Lutomirski , Nick Kossifidis , Russell King , Russell King , Len Brown , Palmer Dabbelt , "Kirill A. Shutemov" , Andrew Morton , Albert Ou , Heiko Carstens , Catalin Marinas , Frank Rowand , Vasily Gorbik , Thomas Gleixner , Rob Herring , linux-kernel@vger.kernel.org, Mike Rapoport , Christian Borntraeger , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, Ingo Molnar , Guenter Roeck , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dave Hansen , linux-s390@vger.kernel.org, kvmarm@lists.cs.columbia.edu, devicetree@vger.kernel.org Subject: Re: [PATCH v5] memblock: make memblock_find_in_range method private Message-ID: References: <20210816122622.30279-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210816122622.30279-1-rppt@kernel.org> X-Rspamd-Queue-Id: F0258801CFBD Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf06.hostedemail.com: domain of robherring2@gmail.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=robherring2@gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: mc5u315xp6tkdqunjumkkp63qgfybr7a X-HE-Tag: 1629245590-402404 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 16 Aug 2021 15:26:22 +0300, Mike Rapoport wrote: > From: Mike Rapoport > > There are a lot of uses of memblock_find_in_range() along with > memblock_reserve() from the times memblock allocation APIs did not exist. > > memblock_find_in_range() is the very core of memblock allocations, so any > future changes to its internal behaviour would mandate updates of all the > users outside memblock. > > Replace the calls to memblock_find_in_range() with an equivalent calls to > memblock_phys_alloc() and memblock_phys_alloc_range() and make > memblock_find_in_range() private method of memblock. > > This simplifies the callers, ensures that (unlikely) errors in > memblock_reserve() are handled and improves maintainability of > memblock_find_in_range(). > > Signed-off-by: Mike Rapoport > Acked-by: Kirill A. Shutemov > Acked-by: Rafael J. Wysocki # ACPI > Acked-by: Russell King (Oracle) > Acked-by: Nick Kossifidis # riscv > Reviewed-by: Catalin Marinas # arm64 > --- > v5: > * restore the original behaviour on x86 with addition of more elaborate > comment; I will address the issue in memory_map_top_down() in a separate > series. > > v4: https://lore.kernel.org/lkml/20210812065907.20046-1-rppt@kernel.org > * Add patch that prevents the crashes reported by Guenter Roeck on x86/i386 > on QEMU with 256M or 512M of memory and EFI boot enabled. > * Add Acked-by and Reviewed-by, thanks everybidy! > > v3: https://lore.kernel.org/lkml/20210803064218.6611-1-rppt@kernel.org > * simplify check for exact crash kerenl allocation on arm, per Rob > * make crash_max unsigned long long on arm64, per Rob > > v2: https://lore.kernel.org/lkml/20210802063737.22733-1-rppt@kernel.org > * don't change error message in arm::reserve_crashkernel(), per Russell > > v1: https://lore.kernel.org/lkml/20210730104039.7047-1-rppt@kernel.org > > > arch/arm/kernel/setup.c | 20 +++++--------- > arch/arm64/kvm/hyp/reserved_mem.c | 9 +++---- > arch/arm64/mm/init.c | 36 ++++++++----------------- > arch/mips/kernel/setup.c | 14 +++++----- > arch/riscv/mm/init.c | 44 ++++++++++--------------------- > arch/s390/kernel/setup.c | 10 ++++--- > arch/x86/kernel/aperture_64.c | 5 ++-- > arch/x86/mm/init.c | 23 ++++++++++------ > arch/x86/mm/numa.c | 5 ++-- > arch/x86/mm/numa_emulation.c | 5 ++-- > arch/x86/realmode/init.c | 2 +- > drivers/acpi/tables.c | 5 ++-- > drivers/base/arch_numa.c | 5 +--- > drivers/of/of_reserved_mem.c | 12 ++++++--- > include/linux/memblock.h | 2 -- > mm/memblock.c | 2 +- > 16 files changed, 81 insertions(+), 118 deletions(-) > Acked-by: Rob Herring